Port filename PR identity - #3941
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Requesting changes: filename-based --prs matching currently accepts timestamp-slug numeric prefixes, which causes mismatches against the intended behavior and documentation for PR filtering.
What is this? | From workflow: PR Review
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Mpdreamz
requested changes
Aug 26, 2026
lcawl
marked this pull request as draft
August 27, 2026 01:01
lcawl
force-pushed
the
changelog-registry-followup
branch
from
August 27, 2026 19:14
ec718a5 to
90fec96
Compare
lcawl
marked this pull request as ready for review
August 27, 2026 19:17
Mpdreamz
approved these changes
Aug 31, 2026
lcawl
enabled auto-merge (squash)
August 31, 2026 15:55
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/3941/ Sample changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3911 tried to fix stale CDN pool listings by bringing back
changelog/{org}/{repo}/{branch}/registry.json. That approach was rejected (review): discovery should be PR-keyed GETs, not an unbounded per-branch index. That architecture is already onmain(#3922–#3930).One keep-item from that review did not land: local
--prsmatching must use the same identity as git-ref. Local--prsstill joined only on YAMLprs:. After an author stripsprs:from a PR-numbered file (12345.yaml), local--prsmissed it even though the file name carries the PR. CDN--prswas already fine (it probes{n}.yamlwithIncludeAll).What
Share filename PR identity with local
--prs(and any matcher path that usesChangelogEntryMatcher):prs:prs:-stripped{n}.yamlstill matches local--prs--filesfor precise path selection{n}.yamlwithlink: {canonical}), not combined123-456.yamlfilenamesGit-range already had this logic; it now uses the shared helper instead of a private copy.
CDN
--prsis unchanged: it still probes{n}.yamldirectly. This PR does not restore poolregistry.jsonreconcile.Generative AI disclosure
Did you use a generative AI (GenAI) tool to assist in creating this contribution?
Tool(s) and model(s) used: Cursor Grok 4.5