-
Notifications
You must be signed in to change notification settings - Fork 44
Port filename PR identity #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/services/Elastic.Changelog/Bundling/ChangelogPrIdentity.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Licensed to Elasticsearch B.V under one or more agreements. | ||
| // Elasticsearch B.V licenses this file to you under the Apache 2.0 License. | ||
| // See the LICENSE file in the project root for more information | ||
|
|
||
| namespace Elastic.Changelog.Bundling; | ||
|
|
||
| /// <summary> | ||
| /// Shared identity for matching a changelog entry to a pull request: leading numeric filename | ||
| /// segments or normalized YAML <c>prs:</c> references. | ||
| /// </summary> | ||
| internal static class ChangelogPrIdentity | ||
| { | ||
| /// <summary> | ||
| /// Parses PR numbers from the leading dash-separated numeric segments of an entry file name | ||
| /// (for example <c>123.yaml</c>). Leftover hyphenated names may still yield leading digits. | ||
| /// Current multi-PR authoring writes one <c>{n}.yaml</c> per PR; after upload the scrubber | ||
| /// adds <c>{extra}.yaml</c> markers with <c>link: {canonical}</c> rather than combined | ||
| /// filenames. File names survive scrubbing, so this match works when <c>prs:</c> is absent | ||
| /// from the YAML the matcher reads (including local files where an author removed <c>prs:</c>). | ||
| /// </summary> | ||
| public static IReadOnlyList<int> ParseLeadingPrNumbers(string fileName) | ||
| { | ||
| var stem = fileName; | ||
| var extensionIndex = stem.LastIndexOf('.'); | ||
| if (extensionIndex > 0) | ||
| stem = stem[..extensionIndex]; | ||
|
|
||
| var numbers = new List<int>(); | ||
| foreach (var segment in stem.Split('-')) | ||
| { | ||
| if (segment.Length > 0 && segment.All(char.IsAsciiDigit) && int.TryParse(segment, out var number)) | ||
| numbers.Add(number); | ||
| else | ||
| break; | ||
| } | ||
|
|
||
| return numbers; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Extracts the PR number from a value already normalized by | ||
| /// <see cref="ChangelogBundlingService.NormalizePrForComparison"/> (<c>owner/repo#n</c>). | ||
| /// </summary> | ||
| public static bool TryParseNumberFromNormalized(string normalized, out int number) | ||
| { | ||
| number = 0; | ||
| var hash = normalized.LastIndexOf('#'); | ||
| if (hash < 0 || hash == normalized.Length - 1) | ||
| return false; | ||
| return int.TryParse(normalized[(hash + 1)..], out number); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.