Repository navigation
Viable-model check: interpolate the missing transitions into the error - #62
Merged
Conversation
… error
glue_collapse() does not interpolate, so the error printed the literal
{toString(missing_models)}. Also name the select_score the check requires,
since a model without that crossval score counts as missing.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D1LLswXe3jLjGTFrBsxgPf
mmyrte
added this pull request to stack #67
October 6, 2026 09:43
mmyrte
commented
Oct 7, 2026
…o claude/gifted-lamport-41q8gv-04-missing-models-message
stop() concatenates its arguments, so the message parts carry their own newlines (.trim = FALSE keeps them; glue's trimming had also swallowed the newlines between the failed-model entries). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D1LLswXe3jLjGTFrBsxgPf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/6, on top of #61.
What
.check_viable_trans_models()built its error withglue_collapse(), which does not interpolate, so users saw the literal{toString(missing_models)}. The first line is nowglue()d. The second line now names theselect_scorethat a model must carry, since a model without that crossval score also counts as missing.Tests
The existing expectation in
test_integ_trans_models_t.Rnow matches the interpolated message ("…transition(s): 1, 2.").🤖 Generated with Claude Code
https://claude.ai/code/session_01D1LLswXe3jLjGTFrBsxgPf
Generated by Claude Code