fix(db): index cache_entries.locationId so storage cleanup stops locking SQLite - #266
Merged
Merged
Conversation
Closes #260 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
cleanup:storage-locationslooks for storage locations that no cache entry points to.cache_entries.locationIdhad no index, so for every storage location the query scanned the wholecache_entriestable. With tens of thousands of rows on SQLite this ran for 30+ seconds, held up writes withSQLITE_BUSY, and caused health probe timeouts and pod restarts. A new migration adds the index, which turns each lookup into an index search.📦 Changes
$6_cache_entries_locationId_indexthat createsidx_cache_entries_locationIdoncache_entries(locationId)DROP INDEX ... ON tableon MySQL, which requires it. The down steps of$2and$3were broken on MySQL before✅ Verification
pnpm type-check: passpnpm lint: passpnpm build: passpnpm test:run(sqlite, postgres, mysql with filesystem storage): 41 passed, 2 skipped🔍 Reviews
Not fixed: on MySQL, InnoDB may drop its implicit foreign key index once this index exists, so rolling back this migration could fail with error 1553. This only affects
down. Nothing runs down migrations today, so I left it alone.🔗 Issues
Closes #260
cleanup:partsandcleanup:storage-locationsone after the other instead of at the same time. This PR doesn't do that.🤖 Generated with Claude Code