Skip to content

fix(db): index cache_entries.locationId so storage cleanup stops locking SQLite #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LouisHaftmann merged 2 commits into from
Sep 13, 2026
Merged

fix(db): index cache_entries.locationId so storage cleanup stops locking SQLite #266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a60700
fix(db): index cache_entries.locationId to keep storage cleanup fast
LouisHaftmann Sep 13, 2026
d8c5f5a
fix(db): drop indexes with MySQL-compatible syntax in down migrations
LouisHaftmann Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions lib/migrations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { Hookable } from 'hookable'
import type { Kysely } from 'kysely'
import type { Migration } from 'kysely/migration'
import type { Env } from './schemas'
import { Storage } from './storage'
Expand All @@ -9,6 +10,12 @@ export function migrations(
afterMigrate: () => Promise<void>
}>,
) {
// MySQL requires `DROP INDEX ... ON table`, other drivers reject it
async function dropIndex(db: Kysely<unknown>, index: string, table: string) {
const query = db.schema.dropIndex(index)
await (driver === 'mysql' ? query.on(table) : query).execute()
}

return {
$0_init: {
async up(db) {
Expand Down Expand Up @@ -110,9 +117,9 @@ export function migrations(
await db.schema.createIndex('idx_uploads_scope').on('uploads').columns(['scope']).execute()
},
async down(db) {
await db.schema.dropIndex('idx_cache_entries_scope').execute()
await dropIndex(db, 'idx_cache_entries_scope', 'cache_entries')
await db.schema.alterTable('cache_entries').dropColumn('scope').execute()
await db.schema.dropIndex('idx_uploads_scope').execute()
await dropIndex(db, 'idx_uploads_scope', 'uploads')
await db.schema.alterTable('uploads').dropColumn('scope').execute()
},
},
Expand Down Expand Up @@ -152,9 +159,9 @@ export function migrations(
.execute()
},
async down(db) {
await db.schema.dropIndex('idx_cache_entries_repoId').execute()
await dropIndex(db, 'idx_cache_entries_repoId', 'cache_entries')
await db.schema.alterTable('cache_entries').dropColumn('repoId').execute()
await db.schema.dropIndex('idx_uploads_repoId').execute()
await dropIndex(db, 'idx_uploads_repoId', 'uploads')
await db.schema.alterTable('uploads').dropColumn('repoId').execute()
},
},
Expand Down Expand Up @@ -201,5 +208,17 @@ export function migrations(
await db.schema.alterTable('storage_locations').dropColumn('sizeBytes').execute()
},
},
$6_cache_entries_locationId_index: {
async up(db) {
await db.schema
.createIndex('idx_cache_entries_locationId')
.on('cache_entries')
.columns(['locationId'])
.execute()
},
async down(db) {
await dropIndex(db, 'idx_cache_entries_locationId', 'cache_entries')
},
},
} satisfies Record<string, Migration>
}