Repository navigation
fix(reusable-ci): pin gha-ci-workflow-helpers at v1.1.7-rc.8 so frontend-run failures fail the job - #383
Merged
Conversation
…xit-code fix Under the previous pin (4b5f4d45, labelled v1.1.4) the frontend-run command exited 0 when the npm script failed, so a failing frontend test or E2E run was reported as a pass. Re-pin all 13 references to v1.1.7-rc.8 (ca7caa417), which contains gha-ci-workflow-helpers#29. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011To9HQUWYYqyWHoXYmEi6Z
github-actions
Bot
added
size/M
github-actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reusable-ci.ymlcalledfalkcorp/gha-ci-workflow-helpers@4b5f4d45at all 13 uses. That pin was labelled# v1.1.4, but tag v1.1.4 actually points at9272530a. At that versionfrontend-runexits 0 even when the npm script fails, so a failing frontend or E2E suite showed as green.This PR moves every use to
ca7caa4172a20983df0f93c16e4637669fa002f4(tag v1.1.7-rc.8). That tag includes gha-ci-workflow-helpers#29, which makesfrontend-runexit non-zero when the npm script fails.The new pin is 11 commits past the old one. Only
action.ymlis read by callers. Here is what those 11 commits contain:Effect on consumers: repos whose frontend or E2E scripts fail today will now go red instead of green.
🤖 Generated with Claude Code
https://claude.ai/code/session_011To9HQUWYYqyWHoXYmEi6Z