Skip to content

fix(reusable-ci): pin gha-ci-workflow-helpers at v1.1.7-rc.8 so frontend-run failures fail the job #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdfalk merged 1 commit into from
Oct 30, 2026
Merged

fix(reusable-ci): pin gha-ci-workflow-helpers at v1.1.7-rc.8 so frontend-run failures fail the job #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/guid-index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@
"path": ".github/workflows/reusable-ci.yml",
"guid": "reusable-ci-2025-09-24-core-workflow",
"title": "Reusable CI Workflow",
"version": "1.19.3",
"version": "1.19.4",
"header_path": ".github/workflows/reusable-ci.yml",
"path_mismatch": false
},
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/reusable-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# file: .github/workflows/reusable-ci.yml
# version: 1.19.3
# version: 1.19.4
# guid: reusable-ci-2025-09-24-core-workflow
# last-edited: 2026-10-27

Expand Down Expand Up @@ -657,15 +657,15 @@ jobs:
sudo apt-get install -y $PACKAGES

- name: Build Go project
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: go-setup

# go test reads test flags such as -timeout from GOFLAGS; go build and
# go tool cover ignore flags they do not know, so this only reaches tests.
- name: Test Go project
if: ${{ !inputs.skip-tests }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
env:
GOFLAGS: ${{ inputs.go-test-timeout != '' && format('-timeout={0}', inputs.go-test-timeout) || '' }}
with:
Expand Down Expand Up @@ -759,7 +759,7 @@ jobs:
echo "GHCOMMON_SCRIPTS_DIR=$PWD/ghcommon-workflow-scripts/.github/workflows/scripts" >> "$GITHUB_ENV"

- name: Install Python dependencies
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: python-install

Expand All @@ -772,7 +772,7 @@ jobs:

- name: Test Python code
if: ${{ !inputs.skip-tests }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: python-run-tests

Expand Down Expand Up @@ -839,13 +839,13 @@ jobs:

- name: Format Rust code
if: ${{ !inputs.skip-linting }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: rust-format

- name: Lint Rust code
if: ${{ !inputs.skip-linting }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: rust-clippy

Expand Down Expand Up @@ -931,14 +931,14 @@ jobs:
# No additional cache setup needed here.

- name: Install dependencies
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: frontend-install
frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }}

- name: Lint frontend code
if: ${{ !inputs.skip-linting }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: frontend-run
frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }}
Expand All @@ -947,7 +947,7 @@ jobs:
frontend-failure-message: '❌ Linting failed or not configured'

- name: Build frontend
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: frontend-run
frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }}
Expand All @@ -957,7 +957,7 @@ jobs:

- name: Test frontend
if: ${{ !inputs.skip-tests }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: frontend-run
frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }}
Expand Down Expand Up @@ -986,7 +986,7 @@ jobs:

- name: Run E2E tests
if: ${{ !inputs.skip-tests && !inputs.skip-e2e-tests }}
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: frontend-run
frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }}
Expand Down Expand Up @@ -1149,7 +1149,7 @@ jobs:
} >> "$GITHUB_ENV"

- name: Generate summary
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: generate-ci-summary
env:
Expand All @@ -1164,7 +1164,7 @@ jobs:
JOB_DOCS: skipped

- name: Check overall status
uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4
uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8
with:
command: check-ci-status
env:
Expand Down
3 changes: 3 additions & 0 deletions changelog.d/20261027_bump_ci_helpers_frontend_run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- reusable-ci: gha-ci-workflow-helpers is pinned to v1.1.7-rc.8 (was a v1.1.4-labelled SHA). Under the old pin the `frontend-run` command exited 0 when the npm script failed, so a failing frontend unit or E2E run was reported as a pass; it now fails the step.
Loading