Repository navigation
Conversation
删除子菜单指示、CopyButton 和 Toaster 中手写的 1.75 描边,让它们与组件库其它 Lucide 图标统一使用 2。 不引入主仓库图标层变量,保持独立使用 felinics/ui 时对已发布 @memohai/icon 的依赖边界。
2 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author
Type
Summary
组件库的子菜单方向指示、CopyButton 和 Toaster 仍把图标描边手写为 1.75,而组件库其它 Lucide 图标使用 2。同一界面中因此出现两种图标粗细。
本 PR 只删除这些 1.75 覆盖,让相关图标使用 Lucide 的 2:
menuIndicatorStrokeWidth及 DropdownMenu、ContextMenu 两个调用处的属性传递。不改变尺寸、布局、交互或公开 API,也不引入
@memohai/icon/ui变量依赖:独立使用 felinics/ui 时依赖的是已发布的@memohai/icon,不能假设它包含主仓库尚未发布的导出。showcase 和其它描边值不在本 PR 范围。Memoh 主仓库的子模块指针待本 PR 合并后,再由 MEMOH-212 的 PR 更新。
Related Issues
Validation
自动检查(Agent 已执行)
pnpm type-check:通过。pnpm build:通过;仅有既有的 chunk 大小提示。git diff --check:通过。src中不再有menuIndicatorStrokeWidth或stroke-width="1.75"。实际界面与人工验证
Screenshots / Recordings
待补:从当前运行版本截取子菜单及相关组件的实际界面;本地路径不会作为上传证据。
Human QA