Skip to content

feat: 组件图标描边统一为 2 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
qqqqqf-q wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: 组件图标描边统一为 2 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/components/context-menu/ContextMenuSubTrigger.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
ContextMenuSubTrigger,
useForwardProps,
} from 'reka-ui'
import { menuIndicatorStrokeWidth, menuItemClass } from '#/lib/menu'
import { menuItemClass } from '#/lib/menu'
import { cn } from '#/lib/utils'

const props = defineProps<ContextMenuSubTriggerProps & { class?: HTMLAttributes['class'], inset?: boolean }>()
Expand All @@ -29,9 +29,6 @@ const forwardedProps = useForwardProps(delegatedProps)
)"
>
<slot />
<ChevronRight
:stroke-width="menuIndicatorStrokeWidth"
class="ml-auto"
/>
<ChevronRight class="ml-auto" />
</ContextMenuSubTrigger>
</template>
2 changes: 0 additions & 2 deletions src/components/copy-button/CopyButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,11 @@
<CopyAnimatedCheckIcon
v-if="copied"
:class="iconClass"
:stroke-width="1.75"
/>
<!-- Mirrored so the stacked squares read top-left over bottom-right. -->
<CopyConnectedIcon
v-else
:class="[iconClass, '-scale-x-100']"
:stroke-width="1.75"
/>
</span>
</Transition>
Expand Down
7 changes: 2 additions & 5 deletions src/components/dropdown-menu/DropdownMenuSubTrigger.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
DropdownMenuSubTrigger,
useForwardProps,
} from 'reka-ui'
import { menuIndicatorStrokeWidth, menuItemClass } from '#/lib/menu'
import { menuItemClass } from '#/lib/menu'
import { cn } from '#/lib/utils'

const props = defineProps<DropdownMenuSubTriggerProps & { class?: HTMLAttributes['class'], inset?: boolean }>()
Expand All @@ -27,9 +27,6 @@ const forwardedProps = useForwardProps(delegatedProps)
)"
>
<slot />
<ChevronRight
:stroke-width="menuIndicatorStrokeWidth"
class="ml-auto size-4"
/>
<ChevronRight class="ml-auto size-4" />
</DropdownMenuSubTrigger>
</template>
2 changes: 0 additions & 2 deletions src/components/sonner/Toaster.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,13 +234,11 @@ onBeforeUnmount(() => {
<CheckIcon
v-if="actionPhase(t) === 'success'"
class="size-[18px]"
:stroke-width="1.75"
aria-hidden="true"
/>
<CopyConnectedIcon
v-else
class="size-[18px] -scale-x-100"
:stroke-width="1.75"
aria-hidden="true"
/>
</Button>
Expand Down
3 changes: 0 additions & 3 deletions src/lib/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,3 @@ export const menuLabelClass = 'text-muted-foreground cursor-default pr-2.5 pl-2

// Short labels retain a comfortable menu width; narrow screens may shrink it.
export const menuWidthClass = 'min-w-[min(var(--menu-min-width),calc(100vw-1rem))]'

// Shared stroke for submenu direction hints.
export const menuIndicatorStrokeWidth = 1.75
Loading