Repository navigation
fix: serialize shared account credentials and await logout cleanup - #6
Closed
vani11agirl wants to merge 1 commit into
Closed
vani11agirl wants to merge 1 commit into
vani11agirl wants to merge 1 commit into
Conversation
Collaborator
|
Please clarify what the issue is & what the PR addresses.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account operations previously used only a launcher-local semaphore, allowing refresh rotation to race the injected DLL. Failed refresh/profile cleanup also queued a later logout that could remove a subsequently signed-in account.
Use the same per-Windows-user named mutex as https://github.com/flarialmc/dll-css/pull/1019 across refresh, credential commit, and logout. Preserve the local async gate, keep browser authorization outside the shared lease, and retain mutex ownership on one worker thread across async work. Cleanup now completes within its current transaction, and logout always clears beta access even if the vault is empty.
Validation:
Ship alongside DLL PR #1019 after packaged-launcher/injected-game smoke testing of mutex permissions, vault visibility, refresh, logout, and account switching. Older versions bypass the shared lease, so mixed installations do not provide full coordination. A crash between issuer rotation and persistence can still require signing in again; already-issued JWT revocation is separate.
This draft uses a fork branch. No production vault/endpoints, signing, CDN deployment, workflow dispatch, or merge was performed.