Repository navigation
CI: opt-in apt-only focal/amd64 and bullseye/armhf targets (3.1.x) - #1741
Merged
Merged
Conversation
Add a 'targets' workflow_dispatch input and a plan job that builds the build/apt-install-test matrices from one table. focal/amd64 and bullseye/armhf are opt-in only, so default PR/release runs are unchanged. When targets is set, Docker images are skipped and only the codenames that got packages are regenerated, signed and published. Also stop docker/build-push-action uploading .dockerbuild record artifacts, which the fledge-* download pattern picked up and broke the v3.1.1 publish. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
Light builds were only used for noble; bullseye/armhf now uses them too. Same sed as the full plugin Dockerfile. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: FelixHelin <felix.dumitrascu@helindata.com>
There was a problem hiding this comment.
🟡 Changes recommended
The post-publish sanity check still hardcodes bookworm/amd64 instead of a selected target, so targeted RC publishing can fail after upload or validate an untouched package.
1 open issue
What changed in this PR
Adds opt-in, apt-only builds for existing Fledge 3.1.x installations on focal/amd64 and bullseye/armhf, while preserving the default build targets.
Changes:
- Generates build and apt-install-test matrices from a shared target table.
- Scopes repository updates to selected suites, skips Docker jobs for targeted runs, and disables Docker build-record uploads.
- Updates the lightweight C++ plugin build image to use Debian archive repositories for bullseye.
| File | Description |
|---|---|
.github/workflows/publish-apt-azure.yml |
Adds target selection, dynamic matrices, scoped apt publishing, and Docker controls. |
.ci/plugin-deb/cpp/Dockerfile.light |
Redirects bullseye package sources to Debian archives and disables expiry checks. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backwards-compat apt packages for existing installs: build and publish fledge 3.1.x for Ubuntu 20.04 (focal) amd64 and Debian bullseye armhf, apt only (no Docker images).
targetsworkflow_dispatch input plus aplanjob that generates the build and apt-install-test matrices from a single table.focal/amd64andbullseye/armhfare opt-in only, so default PR, push and release runs build exactly the same set as before.targetsset:DOCKER_BUILD_RECORD_UPLOAD=false:.dockerbuildrecord artifacts matchedpattern: fledge-*and broke the v3.1.1 publish (attempts 3 and 4).Intended use after merge: push a bare tag
v3.1.1-rc.1on the merge commit (no GitHub Release, so nothing triggers automatically), then dispatch this workflow on that tag withdry_run=falseandtargets="focal/amd64 bullseye/armhf". That publishesfledge 3.1.1~rc.1tofocal-rcandbullseye-rc(armhf) only.v3.1.1is untouched.