Skip to content

Follow tizen-core-imf API rename and fix tcore IMF context #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 5 commits into from
Oct 6, 2026
Merged

Follow tizen-core-imf API rename and fix tcore IMF context #203

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88e0acd
Follow tizen-core-imf event callback API rename
JSUYA Sep 30, 2026
e81ed1b
Initialize tizen-core-imf once per process
JSUYA Oct 1, 2026
f156aad
Set device class of tcore IMF key events
JSUYA Oct 1, 2026
ddad910
Initialize input panel state before querying it
JSUYA Oct 1, 2026
8ec3c0d
Count only live tizen-core-imf contexts
JSUYA Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 66 additions & 14 deletions flutter/shell/platform/tizen/tizen_input_method_context_tcore.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

namespace {

int imf_init_count = 0;

tizen_core_imf_input_panel_layout_e TextInputTypeToImfInputPanelLayout(
const std::string& text_input_type) {
if (text_input_type == "TextInputType.text" ||
Expand Down Expand Up @@ -73,6 +75,44 @@ tizen_core_imf_keyboard_locks_e ModifiersToImfLocks(unsigned int modifiers) {
return static_cast<tizen_core_imf_keyboard_locks_e>(locks);
}

void SetImfKeyDeviceClass(tizen_core_imf_event_key_h imf_key,
tizen_core_wl_event_input_base_h ev,
const char* dev_identifier) {
tizen_core_wl_window_h window = nullptr;
tizen_core_wl_display_h display = nullptr;
tizen_core_wl_seat_h seat = nullptr;
GList* devices = nullptr;
if (tizen_core_wl_event_input_base_get_window(ev, &window) !=
TIZEN_CORE_WL_ERROR_NONE ||
tizen_core_wl_window_get_display(window, &display) !=
TIZEN_CORE_WL_ERROR_NONE ||
tizen_core_wl_display_get_default_seat(display, &seat) !=
TIZEN_CORE_WL_ERROR_NONE ||
tizen_core_wl_seat_get_input_device_list(seat, &devices) !=
TIZEN_CORE_WL_ERROR_NONE) {
return;
}

for (GList* node = devices; node; node = node->next) {
auto device = static_cast<tizen_core_wl_input_device_h>(node->data);
const char* identifier = nullptr;
tizen_core_wl_input_device_get_identifier(device, &identifier);
if (identifier && strcmp(identifier, dev_identifier) == 0) {
tizen_core_wl_device_class_e dev_class = TIZEN_CORE_WL_DEVICE_CLASS_NONE;
tizen_core_wl_device_subclass_e dev_subclass =
TIZEN_CORE_WL_DEVICE_SUBCLASS_NONE;
tizen_core_wl_input_device_get_class(device, &dev_class);
tizen_core_wl_input_device_get_subclass(device, &dev_subclass);
tizen_core_imf_event_key_set_device_class(
imf_key, static_cast<tizen_core_imf_device_class_e>(dev_class));
tizen_core_imf_event_key_set_device_subclass(
imf_key, static_cast<tizen_core_imf_device_subclass_e>(dev_subclass));
break;
}
}
g_list_free(devices);
}

tizen_core_imf_event_key_h CreateImfKeyEventFromTcoreWlEvent(void* event) {
auto* ev = static_cast<tizen_core_wl_event_input_base_h>(event);

Expand Down Expand Up @@ -123,6 +163,7 @@ tizen_core_imf_event_key_h CreateImfKeyEventFromTcoreWlEvent(void* event) {
tizen_core_wl_event_input_base_get_device_identifier(ev, &dev_identifier);
if (dev_identifier) {
tizen_core_imf_event_key_set_device_name(imf_key, dev_identifier);
SetImfKeyDeviceClass(imf_key, ev, dev_identifier);
free(dev_identifier);
}

Expand Down Expand Up @@ -155,13 +196,22 @@ bool IsNavigationOrSystemKey(const char* key) {
namespace flutter {

TizenInputMethodContext::TizenInputMethodContext(uintptr_t window_id) {
tizen_core_imf_init();
if (imf_init_count == 0 &&
tizen_core_imf_init() != TIZEN_CORE_IMF_ERROR_NONE) {
FT_LOG(Error) << "Failed to initialize tizen_core_imf.";
return;
}

if (tizen_core_imf_context_create(&imf_context_) !=
TIZEN_CORE_IMF_ERROR_NONE) {
FT_LOG(Error) << "Failed to create tizen_core_imf_context.";
imf_context_ = nullptr;
if (imf_init_count == 0) {
tizen_core_imf_shutdown();
}
return;
}
imf_init_count++;

tizen_core_imf_context_set_client_window(imf_context_,
reinterpret_cast<void*>(window_id));
Expand All @@ -177,9 +227,10 @@ TizenInputMethodContext::~TizenInputMethodContext() {

if (imf_context_) {
tizen_core_imf_context_destroy(imf_context_);
if (--imf_init_count == 0) {
tizen_core_imf_shutdown();
}
}

tizen_core_imf_shutdown();
}

bool TizenInputMethodContext::HandleTcoreWlEventKey(void* event, bool is_down) {
Expand Down Expand Up @@ -293,7 +344,8 @@ bool TizenInputMethodContext::IsInputPanelShown() {
if (!imf_context_) {
return false;
}
tizen_core_imf_input_panel_state_e state;
tizen_core_imf_input_panel_state_e state =
TIZEN_CORE_IMF_INPUT_PANEL_STATE_HIDE;
tizen_core_imf_context_get_input_panel_state(imf_context_, &state);
return state == TIZEN_CORE_IMF_INPUT_PANEL_STATE_SHOW ||
state == TIZEN_CORE_IMF_INPUT_PANEL_STATE_WILL_SHOW;
Expand Down Expand Up @@ -390,7 +442,7 @@ void TizenInputMethodContext::RegisterEventCallbacks() {
self->on_commit_(str);
}
};
tizen_core_imf_context_add_event_callback(
tizen_core_imf_context_add_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_COMMIT,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_COMMIT], this);

Expand All @@ -402,7 +454,7 @@ void TizenInputMethodContext::RegisterEventCallbacks() {
self->on_preedit_start_();
}
};
tizen_core_imf_context_add_event_callback(
tizen_core_imf_context_add_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_START,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_START], this);

Expand All @@ -414,7 +466,7 @@ void TizenInputMethodContext::RegisterEventCallbacks() {
self->on_preedit_end_();
}
};
tizen_core_imf_context_add_event_callback(
tizen_core_imf_context_add_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_END,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_END], this);

Expand All @@ -438,7 +490,7 @@ void TizenInputMethodContext::RegisterEventCallbacks() {
}
}
};
tizen_core_imf_context_add_event_callback(
tizen_core_imf_context_add_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_CHANGED,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_CHANGED], this);
}
Expand All @@ -447,16 +499,16 @@ void TizenInputMethodContext::UnregisterEventCallbacks() {
if (!imf_context_) {
return;
}
tizen_core_imf_context_del_event_callback(
tizen_core_imf_context_del_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_COMMIT,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_COMMIT], this);
tizen_core_imf_context_del_event_callback(
tizen_core_imf_context_del_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_CHANGED,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_CHANGED], this);
tizen_core_imf_context_del_event_callback(
tizen_core_imf_context_del_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_START,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_START], this);
tizen_core_imf_context_del_event_callback(
tizen_core_imf_context_del_event_cb(
imf_context_, TIZEN_CORE_IMF_CALLBACK_PREEDIT_END,
event_callbacks_[TIZEN_CORE_IMF_CALLBACK_PREEDIT_END], this);
}
Expand Down Expand Up @@ -513,7 +565,7 @@ void TizenInputMethodContext::RegisterInputPanelEventCallback() {
return;
}

tizen_core_imf_context_add_input_panel_event_callback(
tizen_core_imf_context_add_input_panel_event_cb(
imf_context_, TIZEN_CORE_IMF_INPUT_PANEL_EVENT_STATE,
InputPanelStateChangedCallback, this);
}
Expand All @@ -523,7 +575,7 @@ void TizenInputMethodContext::UnregisterInputPanelEventCallback() {
return;
}

tizen_core_imf_context_del_input_panel_event_callback(
tizen_core_imf_context_del_input_panel_event_cb(
imf_context_, TIZEN_CORE_IMF_INPUT_PANEL_EVENT_STATE,
InputPanelStateChangedCallback, this);
}
Expand Down
Loading