Repository navigation
Follow tizen-core-imf API rename and fix tcore IMF context - #203
Merged
Merged
Conversation
tizen-core-imf 0.2.22 renamed the context event callback functions from *_event_callback to *_event_cb, keeping the same parameters (including user_data on the del variants). Update the tcore input method context to the new names so it builds against the current Tizen 11.0 packages.
Unlike ecore_imf_init(), tizen_core_imf_init() is not reference counted and must not be called again before tizen_core_imf_shutdown(). Calling shutdown from each context unloads the IME module while other contexts in the same process are still alive. Share a single init among all TizenInputMethodContext instances and log when initialization fails.
The Ecore backend passes the device class and subclass of key events to the input method, but the tcore backend left them as NONE, so the IME could not tell remote control input from keyboard input. Look up the input device by its identifier in the default seat and set its class and subclass on the IMF key event.
IsInputPanelShown() read the state even when tizen_core_imf_context_get_input_panel_state() failed and left it unset. Default it to HIDE.
seungsoo47
reviewed
Oct 2, 2026
The init count was incremented even when tizen_core_imf_init() failed, so the destructor called tizen_core_imf_shutdown() without a matching init and later contexts skipped the initialization. Increment the count only after the context is created and decrement it only when a context is destroyed, so that an instance which failed to initialize never affects the shutdown of the others. If the first context cannot be created, shut down right away to keep the init and shutdown calls paired.
Member
Author
|
https://github.com/flutter-tizen/embedder/actions/runs/36983788343 This PR is needed to fix the CI error in the |
seungsoo47
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tizen-core-imf 0.2.22 renamed the context event callback functions from *_event_callback to *_event_cb. Update the tcore input method context to the new names so it builds against the current Tizen 11.0 packages.
Also fix a few issues in the tcore input method context: