Repository navigation
DIUTILS-9: Fix IndexOutOfBoundsException on MARC 005 field replace in addOrReplaceControlField - #82
Merged
Merged
Conversation
… addOrReplaceControlField
|
psmagin
approved these changes
Sep 30, 2026
viacheslavkol
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
MarcFieldEditor.addOrReplaceControlField throws IndexOutOfBoundsException: Index -1 out of bounds when replacing control field 005.
Approach
Fix addOrReplaceControlField to use removeVariableField/addVariableField instead of getControlFields().set(indexOf(...)), which operated on a defensive copy and silently left the record unchanged.
Changes Checklist
Learning and Resources
DIUTILS-9