Skip to content

DIUTILS-9: Fix IndexOutOfBoundsException on MARC 005 field replace in addOrReplaceControlField #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aliaksandr-Fedasiuk merged 1 commit into from
Sep 30, 2026
+7 −9
Merged

DIUTILS-9: Fix IndexOutOfBoundsException on MARC 005 field replace in addOrReplaceControlField #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* Implement common logic for marc record manipulation ([DIUTILS-8](https://folio-org.atlassian.net/browse/DIUTILS-8))

### Bug fixes
* Description ([ISSUE](https://folio-org.atlassian.net/browse/ISSUE))
* Fix IndexOutOfBoundsException on MARC 005 field replace in addOrReplaceControlField[DIUTILS-9](https://folio-org.atlassian.net/browse/DIUTILS-9)

### Tech Dept
* Restructured the repository into a multi-module Maven project: the root is now an aggregator/parent POM (`data-import-utils-parent`) and the production code moved to the new `data-import-support` module
Expand Down
14 changes: 6 additions & 8 deletions data-import-support/src/main/java/org/folio/dataimport/util/marc/MarcFieldEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,15 @@ private MarcFieldEditor() {
* @param replace if true, replaces an existing field with the same tag; if false, appends a new field
*/
public static void addOrReplaceControlField(Record marcRecord, String tag, String value, boolean replace) {
var newControlField = MarcFactory.newInstance().newControlField(tag, value);
if (replace) {
var currentField = (ControlField) marcRecord.getVariableField(tag);
var newControlField = MarcFactory.newInstance().newControlField(tag, value);
if (currentField != null) {
marcRecord.getControlFields().set(marcRecord.getControlFields().indexOf(currentField), newControlField);
} else {
marcRecord.addVariableField(newControlField);
ControlField existing = (ControlField) marcRecord.getVariableField(tag);
if (existing != null) {
marcRecord.removeVariableField(existing);
}
marcRecord.addVariableField(newControlField);
} else {
ControlField controlField = MarcFactory.newInstance().newControlField(tag, value);
marcRecord.addVariableField(controlField);
marcRecord.addVariableField(newControlField);
}
}

Expand Down
Loading