Skip to content

fix: prefix core.setFailed messages with cross-mark emoji #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnyw4l3n13 merged 2 commits into from
Oct 30, 2026
Merged

fix: prefix core.setFailed messages with cross-mark emoji #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab6339
chore: placeholder for #1014
dnyw4l3n13 Oct 30, 2026
baff792
fix(workflows): prefix core.setFailed messages with cross-mark emoji
dnyw4l3n13 Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/approve-pr/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
script: |
const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number);
if (!Number.isInteger(prNumber) || prNumber <= 0) {
core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.');
core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.');
return;
}
await github.rest.pulls.createReview({
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/assign-pr-to-creator/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
script: |
const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number);
if (!Number.isInteger(prNumber) || prNumber <= 0) {
core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.');
core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.');
return;
}
const pullRequest = process.env.PR_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/check-no-case-sensitivity-conflicts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ runs:
core.error(`Case sensitivity conflict: ${file}`, { file });
}

core.setFailed(`Case sensitivity conflicts found (${offenders.length}).`);
core.setFailed(`❌ Case sensitivity conflicts found (${offenders.length}).`);
2 changes: 1 addition & 1 deletion .github/actions/check-no-ignored-files/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ runs:
core.error(`Ignored file found: ${file}`, { file });
}

core.setFailed(`Found ignored files (${ignoredFiles.length}).`);
core.setFailed(`❌ Found ignored files (${ignoredFiles.length}).`);
4 changes: 2 additions & 2 deletions .github/actions/check-no-merge-commits/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ runs:
script: |
const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number);
if (!Number.isInteger(prNumber) || prNumber <= 0) {
core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.');
core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.');
return;
}
const commits = await github.paginate(github.rest.pulls.listCommits, {
Expand All @@ -35,7 +35,7 @@ runs:
for (const commit of mergeCommits) {
core.error(`Merge commit: ${commit.sha} - ${commit.commit.message.split('\n')[0]}`);
}
core.setFailed(`Found ${mergeCommits.length} merge commit(s). Please rebase instead of merging.`);
core.setFailed(`❌ Found ${mergeCommits.length} merge commit(s). Please rebase instead of merging.`);
} else {
core.info('No merge commits found.');
}
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/check-no-merge-conflicts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
return;
}
core.setFailed(`git grep failed (exit ${error.status}): ${error.stderr || error.message}`);
core.setFailed(`❌ git grep failed (exit ${error.status}): ${error.stderr || error.message}`);
return;
}
Expand All @@ -41,4 +41,4 @@ runs:
core.error(`Merge conflict found in ${file}`, { file });
}
core.setFailed('Found merge conflicts.');
core.setFailed('❌ Found merge conflicts.');
2 changes: 1 addition & 1 deletion .github/actions/enable-automerge/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ runs:
const mergeMethod = process.env.MERGE_METHOD;
const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number);
if (!Number.isInteger(prNumber) || prNumber <= 0) {
core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.');
core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.');
return;
}
const pullRequest = process.env.PR_NUMBER
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ jobs:
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
with:
script: |
core.setFailed('Changelog has not changed')
core.setFailed('❌ Changelog has not changed')

# @@required: merge
change-log-entry-is-in-unreleased:
Expand Down
Loading