feat(core): Add safeCallback helper for isolating user-provided callbacks - #23760
Draft
msonnb wants to merge 1 commit into
Draft
feat(core): Add safeCallback helper for isolating user-provided callbacks#23760msonnb wants to merge 1 commit into
safeCallback helper for isolating user-provided callbacks#23760msonnb wants to merge 1 commit into
Conversation
…backs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
msonnb
changed the title
safeCallback helper for isolating user-provided callbackssafeCallback helper for isolating user-provided callbacks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bb9a102. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
safeCallback(message, fn, fallback)helper which runs a user-provided callback, and on a sync throw or async rejection logsmessageviadebug.errorand returnsfallback(error)instead of propagating.applyBeforeSendSpanCallbackand the undicisafeExecuteare refactored onto the helper so there is a single implementation.First step of #23755, next PR will wrap the rest of the user-defined callbacks.