ref(ui): Drop optional args unused outside tests - #122624
Closed
JonasBa wants to merge 18 commits into
Closed
Conversation
JonasBa
marked this pull request as ready for review
August 25, 2026 18:22
JonasBa
marked this pull request as draft
August 25, 2026 18:23
github-actions
Bot
added
the
Scope: Frontend
Contributor
Author
|
This is the layer above #122373. Files tab includes that PR because GitHub stacks need both branches on getsentry/sentry (these heads are on the fork). Unique diff: JonasBa:jonas/unused-optional-args-cleanup...JonasBa:jonas/unused-optional-args-production |
3 tasks
JonasBa
commented
Aug 26, 2026
JonasBa
left a comment
JonasBa
left a comment
Contributor
Author
There was a problem hiding this comment.
same pass as 122373. this layer is supposed to drop test-only args, but a few of those drops left production no-ops (onResize: () => {}, always-undefined slider bounds, a retry loop with maxTries = 1). follow the unused arg through and delete the now-dead branches.
JonasBa
force-pushed
the
jonas/unused-optional-args-production
branch
from
August 26, 2026 18:28
466c9cf to
553c281
Compare
…vided. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Aug 31, 2026
Contributor
Author
|
Superseded by the same folder-scoped split as #122373 (this layer is folded into those PRs). See the comment there for the full list (#123200–#123237). Closing this PR in favor of those. @TkDodo @nsdeschenes |
scttcper
pushed a commit
that referenced
this pull request
Sep 1, 2026
…#123222) Split out of #122373 and #122624 so this folder can be reviewed on its own (~197 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/views`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/views/alerts/wizard/utils.tsx` - `static/app/views/autofixIssuesDemo/useAutofixIssues.tsx` - `static/app/views/issueDetails/groupFeatureFlags/hooks/useGroupFeatureFlags.tsx` - `static/app/views/issueDetails/sidebar/seerDrawer.tsx` - `static/app/views/issueDetails/useAssignIssueMutation.ts` - `static/app/views/issueDetails/utils.tsx` - `static/app/views/navigation/primary/whatsNew.tsx` - `static/app/views/navigation/secondary/sections/issues/issueViews/useUpdateGroupSearchViewLastVisited.tsx` - `static/app/views/preprod/snapshots/main/snapshotDiffBodies.tsx` - `static/app/views/preprod/utils/releasesUrl.ts` - `static/app/views/seerWorkflows/overview/overviewIssueAssignee.spec.tsx` - `static/app/views/seerWorkflows/overview/overviewIssueAssignee.tsx` - `static/app/views/seerWorkflows/overview/useIsInView.ts` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/views`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
TkDodo
added a commit
that referenced
this pull request
Sep 2, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~18 LOC). ## Summary - Remove unused optional arguments and fields under `scripts`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `scripts/type-coverage.ts` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `scripts`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
TkDodo
added a commit
that referenced
this pull request
Sep 2, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~155 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/components/forms`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/components/forms/controls/rangeSlider/index.spec.tsx` - `static/app/components/forms/controls/rangeSlider/index.tsx` - `static/app/components/forms/formPanel.tsx` - `static/app/components/forms/jsonForm.spec.tsx` - `static/app/components/forms/jsonForm.tsx` - `static/app/components/forms/model.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/components/forms`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io> Co-authored-by: Dominik Dorfmeister 🔮 <office@dorfmeister.cc>
scttcper
pushed a commit
that referenced
this pull request
Sep 2, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~200 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/components`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/components/aiPrivacyTooltip.tsx` - `static/app/components/group/assigneeSelector.tsx` - `static/app/components/issues/groupList.spec.tsx` - `static/app/components/issues/groupList.tsx` - `static/app/components/pipeline/usePipeline.spec.tsx` - `static/app/components/pipeline/usePipeline.tsx` - `static/app/components/platformPicker.tsx` - `static/app/components/tours/tourContext.spec.tsx` - `static/app/components/tours/tourContext.tsx` - `static/app/components/tours/useAssistant.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/components`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com>
scttcper
pushed a commit
that referenced
this pull request
Sep 2, 2026
…123218) Split out of #122373 and #122624 so this folder can be reviewed on its own (~186 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/utils`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/utils/analytics/makeAnalyticsFunction.tsx` - `static/app/utils/demoMode/demoTours.spec.tsx` - `static/app/utils/members/useMembers.tsx` - `static/app/utils/number/formatPercentage.spec.tsx` - `static/app/utils/number/formatPercentage.tsx` - `static/app/utils/performanceForSentry/index.tsx` - `static/app/utils/repositories/repoQueryOptions.ts` - `static/app/utils/string/trimCommonAffixes.spec.tsx` - `static/app/utils/string/trimCommonAffixes.tsx` - `static/app/utils/timeSeries/determineSeriesConfidence.tsx` - `static/app/utils/tokenizeSearch.tsx` - `static/app/utils/useCommitters.tsx` - `static/app/utils/useDispatchingReducer.spec.tsx` - `static/app/utils/useDispatchingReducer.tsx` - `static/app/utils/useIssueEventOwners.tsx` - `static/app/utils/useKeyPress.tsx` - `static/app/utils/useReleaseStats.tsx` - `static/app/utils/useResizable.tsx` - `static/app/utils/useResizableDrawer.tsx` - `static/app/utils/useTeams.tsx` - `static/app/utils/window/useFullscreen.tsx` - `static/app/utils/withApi.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/utils`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
TkDodo
added a commit
that referenced
this pull request
Sep 3, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~99 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/actionCreators`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/actionCreators/dashboards.tsx` - `static/app/actionCreators/events.tsx` - `static/app/actionCreators/group.tsx` - `static/app/actionCreators/modal.tsx` - `static/app/actionCreators/navigation.tsx` - `static/app/actionCreators/organizations.tsx` - `static/app/actionCreators/projects.tsx` - `static/app/actionCreators/prompts.tsx` - `static/app/actionCreators/savedSearches.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/actionCreators`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
nsdeschenes
pushed a commit
that referenced
this pull request
Sep 3, 2026
) Split out of #122373 and #122624 so this folder can be reviewed on its own (~199 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/views/dashboards`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/views/dashboards/dashboard.spec.tsx` - `static/app/views/dashboards/dashboard.tsx` - `static/app/views/dashboards/datasetConfig/formatTraceMetricsFunction.tsx` - `static/app/views/dashboards/datasetConfig/logs.tsx` - `static/app/views/dashboards/datasetConfig/spans.tsx` - `static/app/views/dashboards/datasetConfig/traceMetrics.spec.tsx` - `static/app/views/dashboards/datasetConfig/traceMetrics.tsx` - `static/app/views/dashboards/widgetCard/issueWidgetQueries.tsx` - `static/app/views/dashboards/widgetCard/widgetQueries.tsx` - `static/app/views/dashboards/widgetLegendSelectionState.tsx` ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
nsdeschenes
added a commit
that referenced
this pull request
Sep 3, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~102 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/utils/profiling`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/utils/profiling/canvasView.tsx` - `static/app/utils/profiling/gl/utils.spec.tsx` - `static/app/utils/profiling/gl/utils.ts` - `static/app/utils/profiling/hooks/useProfileEvents.tsx` - `static/app/utils/profiling/hooks/useProfileEventsStats.tsx` - `static/app/utils/profiling/hooks/useProfileFunctionTrends.tsx` - `static/app/utils/profiling/hooks/useProfileFunctions.tsx` - `static/app/utils/profiling/hooks/useProfileTopEventsStats.tsx` - `static/app/utils/profiling/profile/importProfile.tsx` - `static/app/utils/profiling/profile/testUtils.tsx` - `static/app/utils/profiling/renderers/sampleTickRenderer.tsx` - `static/app/utils/profiling/renderers/selectedFrameRenderer.tsx` - `static/app/utils/profiling/routes.tsx` - `static/app/utils/profiling/speedscope.tsx` ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Nick <nicholas.deschenes@sentry.io>
TkDodo
pushed a commit
that referenced
this pull request
Sep 3, 2026
…tar (#123211) Split out of #122373 and #122624 so this folder can be reviewed on its own (~195 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/components/core`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/components/core/avatar/avatar.mdx` - `static/app/components/core/avatar/sentryAppAvatar.spec.tsx` - `static/app/components/core/avatar/sentryAppAvatar.tsx` - `static/app/components/core/badge/alertBadge.spec.tsx` - `static/app/components/core/badge/alertBadge.tsx` - `static/app/components/core/badge/badge.mdx` - `static/app/components/core/chat/thinkingBlock.tsx` - `static/app/components/core/chat/toolCall.mdx` - `static/app/components/core/chat/toolCall.spec.tsx` - `static/app/components/core/chat/toolCall.tsx` - `static/app/components/core/chip/chip.mdx` - `static/app/components/core/chip/chip.spec.tsx` - `static/app/components/core/chip/chip.tsx` - `static/app/components/core/markdown/defaultComponents.tsx` - `static/app/components/core/segmentedControl/segmentedControl.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/components/core`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
TkDodo
added a commit
that referenced
this pull request
Sep 4, 2026
Split out of #122373 and #122624 so this folder can be reviewed on its own (~161 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/views/settings`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/views/settings/components/teamSelect/teamSelectForMember.tsx` - `static/app/views/settings/components/teamSelect/teamSelectForProject.tsx` - `static/app/views/settings/components/teamSelect/utils.tsx` - `static/app/views/settings/dynamicSampling/utils/rebalancing.test.tsx` - `static/app/views/settings/dynamicSampling/utils/rebalancing.tsx` - `static/app/views/settings/featureFlags/changeTracking/organizationFeatureFlagsAuditLogTable.tsx` - `static/app/views/settings/organizationAuth/providerItem.spec.tsx` - `static/app/views/settings/organizationAuth/providerItem.tsx` - `static/app/views/settings/organizationDataForwarding/util/hooks.tsx` - `static/app/views/settings/organizationIntegrations/integrationExternalTeamMappings.tsx` - `static/app/views/settings/organizationIntegrations/integrationExternalUserMappings.tsx` - `static/app/views/settings/organizationRepositories/hooks/organizationConfigIntegrationsQueryOptions.ts` - `static/app/views/settings/organizationRepositories/hooks/organizationIntegrationsQueryOptions.ts` - `static/app/views/settings/organizationRepositories/hooks/useSyncRepositories.spec.tsx` - `static/app/views/settings/organizationRepositories/hooks/useSyncRepositories.tsx` - `static/app/views/settings/project/preprod/types.ts` - `static/app/views/settings/project/projectTeams.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/views/settings`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Dominik Dorfmeister 🔮 <dominik.dorfmeister@sentry.io>
JonasBa
pushed a commit
to JonasBa/sentry
that referenced
this pull request
Sep 4, 2026
TkDodo
pushed a commit
that referenced
this pull request
Sep 4, 2026
#123212) Split out of #122373 and #122624 so this folder can be reviewed on its own (~144 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/components/core`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/components/core/form/field/radioField.spec.tsx` - `static/app/components/core/form/field/radioField.tsx` - `static/app/components/core/form/fields.mdx` - `static/app/components/core/input/useAutosizeInput.tsx` - `static/app/components/core/splitPanel/splitPanel.spec.tsx` - `static/app/components/core/splitPanel/splitPanel.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/components/core`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
TkDodo
pushed a commit
that referenced
this pull request
Sep 4, 2026
…bar (#123209) Split out of #122373 and #122624 so this folder can be reviewed on its own (~142 LOC). ## Summary - Remove unused optional arguments and fields under `static/app/components`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/components/backendJsonFormAdapter/choiceMapperAdapter.tsx` - `static/app/components/mentionInput/mentionInput.tsx` - `static/app/components/percentChange.tsx` - `static/app/components/profiling/flamegraph/collapsibleTimeline.tsx` - `static/app/components/profiling/flamegraph/interactions/useWheelCenterZoom.tsx` - `static/app/components/progressMarker.tsx` - `static/app/components/replays/canvasReplayerPlugin.tsx` - `static/app/components/searchSyntax/mutableSearch.tsx` - `static/app/components/timeRangeSelector/utils.tsx` - `static/app/components/tokenizedInput/token/comboBox.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app/components`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
TkDodo
pushed a commit
that referenced
this pull request
Sep 4, 2026
…me (#123203) Split out of #122373 and #122624 so this folder can be reviewed on its own (~121 LOC). ## Summary - Remove unused optional arguments and fields under `static/app`. - Same approach as the original PRs: drop args/fields nothing passes, keep public hook/component options, inline previous defaults. ## Files - `static/app/data/platformCategories.tsx` - `static/app/gettingStartedDocs/javascript/agentMonitoring.tsx` - `static/app/gettingStartedDocs/node/agentMonitoring.tsx` - `static/app/gettingStartedDocs/node/utils.tsx` - `static/app/gettingStartedDocs/python/logs.tsx` - `static/app/gettingStartedDocs/python/metrics.spec.tsx` - `static/app/gettingStartedDocs/python/metrics.tsx` - `static/app/gettingStartedDocs/python/profiling.tsx` - `static/app/gettingStartedDocs/python/utils.tsx` - `static/app/gettingStartedDocs/rust/logs.tsx` - `static/app/gettingStartedDocs/rust/onboarding.tsx` - `static/app/router/routeMapTestUtils.spec.tsx` - `static/app/router/routeMapTestUtils.tsx` - `static/app/stores/guideStore.tsx` - `static/app/stores/onboardingDrawerStore.tsx` - `static/app/styles/animations.tsx` ## Test plan - [ ] CI typecheck / frontend tests for this slice. - [ ] Spot-check call sites in `static/app`. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Jonas Badalic <jbadalic@twitter.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #122373 (same fork branches:
jonas/unused-optional-args-cleanup→jonas/unused-optional-args-production).Official GitHub stacks require both heads on
getsentry/sentry. These branches live onJonasBa/sentry, so this PR currently targetsmaster. Unique layer (this PR only):JonasBa:jonas/unused-optional-args-cleanup...JonasBa:jonas/unused-optional-args-production
Summary
Linkbutton extras,GridColumnHeader.tooltip, callback-provided widget data).Test plan
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.