Skip to content

docs(agents): keep prose out of shell commands - #83

Merged
tonibergholm-codento merged 2 commits into
mainfrom
tonibergholm/cod2-7153-shell-prose
Nov 9, 2026
Merged

tonibergholm-codento merged 2 commits into
mainfrom
tonibergholm/cod2-7153-shell-prose

Conversation

@tonibergholm-codento

Copy link
Copy Markdown
Contributor

Agent instructions now say that PR bodies, reviews, comments and commit messages go in a file passed by path, never inline in a shell command, heredoc or bash -c string.

On 2026-11-09 an agent posted reviews with bash -c '... <<"EOF" ... EOF'. The apostrophe in "that's" ended the quoting, the review text ran as shell code from the Engine main checkout, and a backticked test name containing > returns created a stray returns file there.

The same one-line rule lands in every Engine repository's agent instructions (COD2-7153).

Validation: git diff --check. Documentation only; no code, contract, infrastructure or runtime surface changes.

An apostrophe in a bash -c heredoc ended the quoting and ran review
text as shell code in a main checkout.
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d9df367b-4405-42a1-ab82-0e9f387420d8
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T14:57:59.617474Z 5191808 New commits
🔒 Security Review ✅ Completed 2026-11-09T14:59:13.942588Z 5191808 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Sentinel dependency audit — WARN · ✓ ok

144 allow · 5 warn · 0 block · 0 error
provenance: 44 verified · 0 invalid · 105 absent · 0 unknown

package verdict score finding how to fix
esbuild@0.28.1 warn 62/100 install.js combines launch + write + read primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
fast-uri@3.1.8 warn 75/100 Network egress: connects to a hardcoded IP address. Confirm the egress is expected for this package's purpose; if not, remove it or pin to a version without it.
isexe@2.0.0 warn 77/100 test/basic.js combines read + launch + write primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
tsx@4.22.4 warn 76/100 dist/index-D9F1FXzN.cjs combines read + write primitives — partial materialization pattern. Review the finding details; approve with a recorded rationale only if you understand and accept the risk.
undici-types@7.18.2 warn 64/100 Network egress: imports a raw networking module. Confirm the egress is expected for this package's purpose; if not, remove it or pin to a version without it.

▶ Run sentinel explain <package> <version> for a suggested safe version and a ready waiver.

Sentinel · 149 packages audited · 2026-11-09T14:56:51.952Z · SBOM uploaded as a build artifact

Review follow-up: covers gh api and $(...), exempts titles, and
removes inline-body and heredoc examples from agent docs and skills.
@tonibergholm-codento
tonibergholm-codento merged commit 5b0e11b into main Nov 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant