Guard requestBlankLine in writeTableOpen, writePreOpen, and writeBlockquoteOpenOrClose of JavadocWriter.#1409
Merged
Merged
Conversation
…kquoteOpenOrClose of JavadocWriter. * Prevent inserting leading blank lines (`///`) before `<table>`, `<pre>`, and `<blockquote>` when they appear as the very first token in a Javadoc comment by checking `if (wroteAnythingSignificant)` before requesting a blank line. * Add `tableAtStartOfComment()`, `preAtStartOfComment()`, and `blockquoteAtStartOfComment()` unit tests in `JavadocFormattingTest`. * Add `tableInHtmlListItem()` and `tableInsideMarkdownListItemAfterText()` unit tests in `JavadocFormattingTest` to document existing list-item table spacing behavior (Thread 4 discussion). PiperOrigin-RevId: 945745386
copybara-service
Bot
force-pushed
the
test_945714394
branch
from
2a2ea68 to
77bee2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard requestBlankLine in writeTableOpen, writePreOpen, and writeBlockquoteOpenOrClose of JavadocWriter.
///) before<table>,<pre>, and<blockquote>when they appear as the very first token in a Javadoc comment by checkingif (wroteAnythingSignificant)before requesting a blank line.tableAtStartOfComment(),preAtStartOfComment(), andblockquoteAtStartOfComment()unit tests inJavadocFormattingTest.tableInHtmlListItem()andtableInsideMarkdownListItemAfterText()unit tests inJavadocFormattingTestto document existing list-item table spacing behavior (Thread 4 discussion).