Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -260,15 +260,19 @@ void writeParagraphOpen(Token token) {
}

void writeBlockquoteOpenOrClose(Token token) {
requestBlankLine();
if (wroteAnythingSignificant) {
requestBlankLine();
}

writeToken(token);

requestBlankLine();
}

void writePreOpen(PreOpenTag token) {
requestBlankLine();
if (wroteAnythingSignificant) {
requestBlankLine();
}

writeToken(token);
}
Expand All @@ -288,7 +292,9 @@ void writeCodeClose(CodeCloseTag token) {
}

void writeTableOpen(TableOpenTag token) {
requestBlankLine();
if (wroteAnythingSignificant) {
requestBlankLine();
}

writeToken(token);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2160,14 +2160,100 @@ public void tableAtStartOfComment() {
/// </table>
class Test {}
""";
// TODO(kak): we shouldn't spew out these 2 leading blank lines
String expected = input;
doFormatTest(input, expected);
}

@Test
public void blockquoteAtStartOfComment() {
assume().that(MARKDOWN_JAVADOC_SUPPORTED).isTrue();
String input =
"""
/// <blockquote>
/// line 1
/// line 2
/// </blockquote>
class Test {}
""";
String expected =
"""
/// <blockquote>
///
/// line 1 line 2
///
/// </blockquote>
class Test {}
""";
doFormatTest(input, expected);
}

@Test
public void preAtStartOfComment() {
assume().that(MARKDOWN_JAVADOC_SUPPORTED).isTrue();
String input =
"""
/// <pre>
/// line 1
/// line 2
/// </pre>
class Test {}
""";
String expected = input;
doFormatTest(input, expected);
}

@Test
public void tableInHtmlListItem() {
assume().that(MARKDOWN_JAVADOC_SUPPORTED).isTrue();
String input =
"""
/// <ul>
/// <li>
/// <table>
/// <tr><td>Foo</td></tr>
/// </table>
/// </li>
/// </ul>
class Test {}
""";
// requestBlankLine() in writeTableOpen() inserts a blank line after <li> before <table> when
// inside a list item.
String expected =
"""
/// <ul>
/// <li>
///
/// <table>
/// <tr><td>Foo</td></tr>
/// </table>
///
/// </ul>
class Test {}
""";
doFormatTest(input, expected);
}

@Test
public void tableInsideMarkdownListItemAfterText() {
assume().that(MARKDOWN_JAVADOC_SUPPORTED).isTrue();
String input =
"""
/// - item text
/// <table>
/// <tr><td>Foo</td></tr>
/// </table>
class Test {}
""";
// requestBlankLine() in writeTableOpen() inserts a blank line after item text before <table>
// inside the list item.
String expected =
"""
///
/// - item text
///
/// <table>
/// <tr><td>Foo</td></tr>
/// </table>
class Test {}
""";
doFormatTest(input, expected);
Expand Down
Loading