Skip to content

[ci] Let hook inventory skip data directories - #3572

Open
joshlf wants to merge 1 commit into
Gga2afs3rc7lmrmvkzm4wdcmi4lwlyi65from
Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m
Open

[ci] Let hook inventory skip data directories#3572
joshlf wants to merge 1 commit into
Gga2afs3rc7lmrmvkzm4wdcmi4lwlyi65from
Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m

Conversation

@joshlf

@joshlf joshlf commented Aug 24, 2026

Copy link
Copy Markdown
Member

Authored by Codex, posting via joshlf's account

Check only regular files when verifying that pre-push invokes every CI
check. Preserve the existing reminder for new scripts while allowing
review data to live in a named directory under ci.

Tests: ./githooks/pre-push.


Latest Update: v4 — Compare vs v3

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v3 v2 v1 Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m && git checkout -b pr-Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m FETCH_HEAD

Checkout

git fetch origin refs/heads/Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (da31221) to head (1ae23ca).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           Gga2afs3rc7lmrmvkzm4wdcmi4lwlyi65    #3572   +/-   ##
==================================================================
  Coverage                              91.85%   91.85%           
==================================================================
  Files                                     20       20           
  Lines                                   6093     6093           
==================================================================
  Hits                                    5597     5597           
  Misses                                   496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf
joshlf force-pushed the Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m branch from d61725c to 85273d3 Compare August 24, 2026 23:09
@joshlf
joshlf force-pushed the Gga2afs3rc7lmrmvkzm4wdcmi4lwlyi65 branch 2 times, most recently from b76c6da to d6eb90c Compare August 24, 2026 23:21
@joshlf
joshlf force-pushed the Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m branch from 85273d3 to 4f893f6 Compare August 24, 2026 23:21
@joshlf

joshlf commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

Please review the current head. Treat any earlier review as stale if it targets
a different commit.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 4f893f6fd1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

*Authored by Codex, posting via joshlf's account*

Check only regular files when verifying that pre-push invokes every CI
check. Preserve the existing reminder for new scripts while allowing
review data to live in a named directory under ci.

gherrit-pr-id: Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m
Tests: ./githooks/pre-push.
@joshlf
joshlf force-pushed the Gga2afs3rc7lmrmvkzm4wdcmi4lwlyi65 branch from d6eb90c to da31221 Compare August 24, 2026 23:47
@joshlf
joshlf force-pushed the Gtynnl3k4vyrtzrvdux7rxs4dkq7l7f6m branch from 4f893f6 to 1ae23ca Compare August 24, 2026 23:47
@joshlf

joshlf commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 1ae23caaec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants