[ci] Pin and test repository tools - #3570
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gdqabzhpevkhxg3fzk6bvbtpws7nk2vwv #3570 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13551621a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1355162 to
6ed1263
Compare
6ed1263 to
53a0bf8
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat any earlier review as stale if it targets |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53a0bf853d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
53a0bf8 to
765e70e
Compare
df82221 to
c08a2eb
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 765e70e685
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
765e70e to
896e57f
Compare
c08a2eb to
73337ca
Compare
73337ca to
b0e9d01
Compare
896e57f to
7e0d1ce
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e0d1ce812
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbc3d098fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bbc3d09 to
6b8dd79
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat earlier reviews of older commits as stale. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b8dd79b23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6b8dd79 to
be17ca4
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
be17ca4 to
da5fc11
Compare
b0e9d01 to
aa10436
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da5fc11dbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
da5fc11 to
50bfa32
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50bfa324d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Build repository tools with the exact stable compiler recorded in tools/rust-toolchain.toml and with the checked-in lockfile. Pass the pin to Cargo explicitly and export it for descendant Cargo processes, so neither RUSTUP_TOOLCHAIN nor a persisted rustup directory override can silently select another compiler. Share the Unix bootstrap recognizer between the wrapper and its validation check. Scope each exact assignment to its exact TOML table. Treat only canonical bare table headers as declarations. Reject quoted, mixed, spaced, commented, and array-table aliases of the same semantic path without confusing one quoted component whose literal name contains dots. Validate the fixed table and key inputs before constructing the recognizer. Accept LF and well-formed CRLF, but reject alternate assignments, noncanonical or duplicate tables, multiline strings, NUL bytes, bare carriage returns, unterminated lines, unreadable input, and missing or duplicate declarations. Keep the independent Windows recognizer coordinated with the Unix contract. Require the complete three-line semantic file shape, reject command-interpreter metacharacters before parsing, and avoid CALL's second expansion pass. A future file-format change must update both recognizers deliberately. Run README generation from the tools workspace with the same compiler pin and locked dependencies. Export the pin to its nested cargo-readme process, and report a failed child command before printing any generated framing so redirected output cannot look like a partial regeneration. Document the working and source directories together. Update the tools compiler in the weekly stable roller so the tool and library build paths cannot drift accidentally. Add stable to the serial pre-push bootstrap when the tools check first makes it necessary. Run the complete tools workspace test suite in CI and before each push. Validate that the tools compiler still matches the stable CI compiler, and exercise hostile parser inputs and nested command failure. Tests: ./githooks/pre-push Tests: hostile RUSTUP_TOOLCHAIN ./ci/check_tools.sh Tests: hostile RUSTUP_TOOLCHAIN ./zerocopy/ci/check_readme.sh *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gvc5xhb5dgtwxc6zn6aycox7svxcbv3by
50bfa32 to
78b0999
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Build repository tools with the exact stable compiler recorded in
tools/rust-toolchain.toml and with the checked-in lockfile. Pass the pin
to Cargo explicitly and export it for descendant Cargo processes, so
neither RUSTUP_TOOLCHAIN nor a persisted rustup directory override can
silently select another compiler.
Share the Unix bootstrap recognizer between the wrapper and its
validation check. Scope each exact assignment to its exact TOML table.
Treat only canonical bare table headers as declarations. Reject quoted,
mixed, spaced, commented, and array-table aliases of the same semantic
path without confusing one quoted component whose literal name contains
dots. Validate the fixed table and key inputs before constructing the
recognizer.
Accept LF and well-formed CRLF, but reject alternate assignments,
noncanonical or duplicate tables, multiline strings, NUL bytes, bare
carriage returns, unterminated lines, unreadable input, and missing or
duplicate declarations.
Keep the independent Windows recognizer coordinated with the Unix
contract. Require the complete three-line semantic file shape, reject
command-interpreter metacharacters before parsing, and avoid CALL's
second expansion pass. A future file-format change must update both
recognizers deliberately.
Run README generation from the tools workspace with the same compiler
pin and locked dependencies. Export the pin to its nested cargo-readme
process, and report a failed child command before printing any generated
framing so redirected output cannot look like a partial regeneration.
Document the working and source directories together.
Update the tools compiler in the weekly stable roller so the tool and
library build paths cannot drift accidentally. Add stable to the serial
pre-push bootstrap when the tools check first makes it necessary.
Run the complete tools workspace test suite in CI and before each push.
Validate that the tools compiler still matches the stable CI compiler,
and exercise hostile parser inputs and nested command failure.
Tests: ./githooks/pre-push
Tests: hostile RUSTUP_TOOLCHAIN ./ci/check_tools.sh
Tests: hostile RUSTUP_TOOLCHAIN ./zerocopy/ci/check_readme.sh
Authored by an agent, posting via joshlf's account
Latest Update: v24 — Compare vs v23
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gvc5xhb5dgtwxc6zn6aycox7svxcbv3by && git checkout -b pr-Gvc5xhb5dgtwxc6zn6aycox7svxcbv3by FETCH_HEADCheckout
git fetch origin refs/heads/Gvc5xhb5dgtwxc6zn6aycox7svxcbv3by && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gvc5xhb5dgtwxc6zn6aycox7svxcbv3by && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.