[ci] Require execution parity before planning - #3598
Conversation
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gvwvbb4qvqvk2nt4mdo3fp333lmrtmydn #3598 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d206edd to
483b00c
Compare
01b16a9 to
4fc813f
Compare
4fc813f to
6d4acec
Compare
483b00c to
759330f
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
759330f to
1948b30
Compare
6d4acec to
07225ee
Compare
1948b30 to
22ea145
Compare
07225ee to
0f51326
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
22ea145 to
f161861
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The typed command model helps only if every caller checks it before a plan can escape. Run its full legacy-parity proof while constructing CiInputs, after policy, inventory, workflow, and baselines are trusted. This centralizes the temporary CLI-level gate added with the command model. Validation is now all-or-nothing: new planners and local commands cannot omit the execution audit or consume a model which has drifted from independently captured behavior. Tests: cargo test -p zc --all-targets --offline Tests: cargo clippy -p zc --all-targets --offline -- -D warnings *Authored by an agent, posting via joshlf's account* gherrit-pr-id: Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz
4d8e245 to
b58c1c7
Compare
f161861 to
3bbba2e
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The typed command model helps only if every caller checks it before a
plan can escape. Run its full legacy-parity proof while constructing
CiInputs, after policy, inventory, workflow, and baselines are trusted.
This centralizes the temporary CLI-level gate added with the command
model. Validation is now all-or-nothing: new planners and local commands
cannot omit the execution audit or consume a model which has drifted
from independently captured behavior.
Tests: cargo test -p zc --all-targets --offline
Tests: cargo clippy -p zc --all-targets --offline -- -D warnings
Authored by an agent, posting via joshlf's account
Latest Update: v13 — Compare vs v12
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz && git checkout -b pr-Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz FETCH_HEADCheckout
git fetch origin refs/heads/Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gnp4lv6jrqbhnp5pyd2625o7jwdguulmz && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.