[ci] Run audited semver checks in parallel - #3587
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e53b901bb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e53b901 to
08726ef
Compare
2c3096c to
01b16a9
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
89b8771 to
f9ea695
Compare
08726ef to
762a0dc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gcl7ijadfh2m7eft4ucy5czoaghddreiq #3587 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
231d8b3 to
d0426b3
Compare
6a81fe4 to
5c8b678
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
5c8b678 to
ec0310e
Compare
c54bc3c to
ffb5cd0
Compare
ec0310e to
30dcd81
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ffb5cd0 to
eb2cc83
Compare
b8fe2df to
a083de6
Compare
eb2cc83 to
3c014ce
Compare
a083de6 to
da22c8c
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
38e0cf2 to
7ed08a4
Compare
da22c8c to
6f9c0bc
Compare
7ed08a4 to
bda6d18
Compare
6f9c0bc to
545c5e9
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Move semver checks out of selected build_test cells and into a
standalone target-only matrix derived by the typed planner. Reduced
events select the three targets covered by the matching ordinary-build
slice; full events select all nine configured, non-waived targets.
Publish that matrix and its enable gate with the other checked outputs,
and include every decision in the versioned plan artifact.
Give each semver cell a fresh hosted runner which depends only on
plan_ci. It can start in parallel with Docker image construction and the
ordinary matrix instead of waiting for an image download, image load,
and complete ordinary build in its former build_test cell. The expected
critical-path saving is roughly that formerly serialized setup and build
duration; the exact wall-clock improvement remains runner- and
cache-dependent.
Keep checkout, commit-message skip handling, and the pinned action in
one exactly audited three-step job. Derive the action's static inputs
from checked policy and Cargo metadata, model its logical work and exact
inputs in execution-parity checks, and reject extra job fields, steps,
conditions, environment, or workflow authority.
Use matrix.target for both rust-target and prefix-key. The action's
automatic baseline-rustdoc cache key omits the Rust target. This keeps
concurrent targets from reading and writing one cache entry. Adapt only
the historical job name and missing cache prefix at the frozen-evidence
boundary; the live plan and workflow remain strict.
Extend all-jobs-succeed's planner-controlled optional-job protocol from
Miri to semver. An enabled semver job must succeed, while a disabled job
must produce its corresponding planned skip. Match the total skip count
to both gates so an unrelated skipped dependency cannot pass.
Make build_test end at its typed executor, register the new planned job,
and audit both the target-only matrix consumer and its planner output
protocol. Removing build_test's generated Docker shell must not weaken
its prerequisite boundary: retain the exact setup and anchor audit, the
local-action source snapshot, and the checkout integrity gate directly
before the executor.
Tests: ./tools/cargo.sh test -p zc
Tests: ./tools/cargo.sh clippy -p zc --all-targets --offline --
-D warnings
Tests: ./ci/check_actions.sh
*Authored by an agent, posting via joshlf's account*
gherrit-pr-id: Gqs4rhblhbsqga3glvc6tfjnakpdspo3b
bda6d18 to
e1eeb8b
Compare
545c5e9 to
985bbcd
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Move semver checks out of selected build_test cells and into a
standalone target-only matrix derived by the typed planner. Reduced
events select the three targets covered by the matching ordinary-build
slice; full events select all nine configured, non-waived targets.
Publish that matrix and its enable gate with the other checked outputs,
and include every decision in the versioned plan artifact.
Give each semver cell a fresh hosted runner which depends only on
plan_ci. It can start in parallel with Docker image construction and the
ordinary matrix instead of waiting for an image download, image load,
and complete ordinary build in its former build_test cell. The expected
critical-path saving is roughly that formerly serialized setup and build
duration; the exact wall-clock improvement remains runner- and
cache-dependent.
Keep checkout, commit-message skip handling, and the pinned action in
one exactly audited three-step job. Derive the action's static inputs
from checked policy and Cargo metadata, model its logical work and exact
inputs in execution-parity checks, and reject extra job fields, steps,
conditions, environment, or workflow authority.
Use matrix.target for both rust-target and prefix-key. The action's
automatic baseline-rustdoc cache key omits the Rust target. This keeps
concurrent targets from reading and writing one cache entry. Adapt only
the historical job name and missing cache prefix at the frozen-evidence
boundary; the live plan and workflow remain strict.
Extend all-jobs-succeed's planner-controlled optional-job protocol from
Miri to semver. An enabled semver job must succeed, while a disabled job
must produce its corresponding planned skip. Match the total skip count
to both gates so an unrelated skipped dependency cannot pass.
Make build_test end at its typed executor, register the new planned job,
and audit both the target-only matrix consumer and its planner output
protocol. Removing build_test's generated Docker shell must not weaken
its prerequisite boundary: retain the exact setup and anchor audit, the
local-action source snapshot, and the checkout integrity gate directly
before the executor.
Tests: ./tools/cargo.sh test -p zc
Tests: ./tools/cargo.sh clippy -p zc --all-targets --offline --
-D warnings
Tests: ./ci/check_actions.sh
Authored by an agent, posting via joshlf's account
Latest Update: v29 — Compare vs v28
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gqs4rhblhbsqga3glvc6tfjnakpdspo3b && git checkout -b pr-Gqs4rhblhbsqga3glvc6tfjnakpdspo3b FETCH_HEADCheckout
git fetch origin refs/heads/Gqs4rhblhbsqga3glvc6tfjnakpdspo3b && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gqs4rhblhbsqga3glvc6tfjnakpdspo3b && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.