[ci] Prove typed ownership of build-rs toolchains - #3599
Conversation
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gkr4fd4vz5vegygalblsmjjgpdq3eulsx #3599 +/- ##
====================================================================
Coverage ? 91.85%
====================================================================
Files ? 20
Lines ? 6093
Branches ? 0
====================================================================
Hits ? 5597
Misses ? 496
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1632fd7 to
ed2ac06
Compare
46de7c3 to
50f0868
Compare
a9c3a64 to
234569c
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ee675b9 to
c370bbe
Compare
234569c to
1cec11e
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1cec11e to
bf776ff
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
bf776ff to
ce1213f
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1c5f2a6 to
c8420e6
Compare
ce1213f to
9211778
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fdf9df2 to
84816d5
Compare
858d976 to
7bce93a
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7bce93a to
e71c94e
Compare
358e200 to
c131b7f
Compare
The existing shell check compares package.metadata.build-rs keys with the handwritten workflow matrix. A generated matrix will make that YAML representation opaque to the parser, so establish the replacement invariant before changing matrix authority. Add a focused regression which proves that checked inventory rejects both a manifest metadata key with no typed policy entry and a build-rs policy entry with no manifest metadata key. Policy separately requires each descriptor to have nonempty scopes, and ci audit plans every configured event. Keep the legacy YAML check active in this commit. The following matrix-authority change retires it atomically, so neither PR has a gap between the live workflow and the invariant which protects it. Tests: ci/check_tools.sh Tests: zerocopy/ci/check_all_toolchains_tested.sh Tests: cargo clippy -p zc --all-targets --offline -- -D warnings Tests: git diff --check *Authored by an agent, posting via joshlf's account* gherrit-pr-id: G9897ad03a6cbd7a3472a2b8184fd6ae8
5f450b6 to
834050c
Compare
c131b7f to
a309bd0
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head, |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The existing shell check compares package.metadata.build-rs keys with
the handwritten workflow matrix. A generated matrix will make that YAML
representation opaque to the parser, so establish the replacement
invariant before changing matrix authority.
Add a focused regression which proves that checked inventory rejects
both a manifest metadata key with no typed policy entry and a build-rs
policy entry with no manifest metadata key. Policy separately requires
each descriptor to have nonempty scopes, and ci audit plans every
configured event.
Keep the legacy YAML check active in this commit. The following
matrix-authority change retires it atomically, so neither PR has a gap
between the live workflow and the invariant which protects it.
Tests: ci/check_tools.sh
Tests: zerocopy/ci/check_all_toolchains_tested.sh
Tests: cargo clippy -p zc --all-targets --offline -- -D warnings
Tests: git diff --check
Authored by an agent, posting via joshlf's account
Latest Update: v25 — Compare vs v24
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G9897ad03a6cbd7a3472a2b8184fd6ae8 && git checkout -b pr-G9897ad03a6cbd7a3472a2b8184fd6ae8 FETCH_HEADCheckout
git fetch origin refs/heads/G9897ad03a6cbd7a3472a2b8184fd6ae8 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G9897ad03a6cbd7a3472a2b8184fd6ae8 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.