Skip to content

[ci] Retire the generated-matrix toolchain check - #3596

Merged
joshlf merged 0 commit into
Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcffrom
G9897ad03a6cbd7a3472a2b8184fd6ae8
Aug 25, 2026
Merged

[ci] Retire the generated-matrix toolchain check#3596
joshlf merged 0 commit into
Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcffrom
G9897ad03a6cbd7a3472a2b8184fd6ae8

Conversation

@joshlf

@joshlf joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member

The old shell check compared package.metadata.build-rs keys with the
handwritten workflow matrix. Typed planning now passes that matrix
through fromJSON, so yq sees an expression instead of the expected list.

Make checked inventory and policy the sole owner of this invariant.
Inventory requires manifest metadata keys and policy descriptors to be
exactly equal. Policy requires each descriptor to have nonempty scopes,
and ci audit plans every configured event. Both direct CI and pre-push
run that audit through check_tools.sh.

Remove the obsolete hosted job, yq installation, script, hook child,
workflow registry row, and aggregate dependency. Keep the frozen
execution specs unchanged because they describe their immutable source
commit, not the live workflow.

This removes one runner startup and tool installation from CI and one
duplicate local process from pre-push. It should reduce resource use and
a small amount of aggregate latency, although it is not on the matrix
critical path.

Tests: ci/check_tools.sh
Tests: ci/check_actions.sh
Tests: ci/check_job_dependencies.sh
Tests: githooks/test_pre_push.py
Tests: ci/check_fmt.sh
Tests: git diff --check

Authored by an agent, posting via joshlf's account

joshlf commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Authored by an agent, posting via joshlf's account

GHerrit's partial metadata sync left this PR targeting a later stack branch, so GitHub marked it merged and deleted its managed head branch. I restored that branch at the unchanged commit; the change now continues as #3599, targeting its correct immediate parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant