[ci] Document the typed CI control plane - #3597
Conversation
8ff4775 to
46de7c3
Compare
315605d to
0886255
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gnouzrlnq3bnxeg72jfe7d3xq6jymqqcf #3597 +/- ##
==================================================================
Coverage 91.85% 91.85%
==================================================================
Files 20 20
Lines 6093 6093
==================================================================
Hits 5597 5597
Misses 496 496 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Authored by an agent, posting via joshlf's account @codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
0886255 to
875184e
Compare
b221e68 to
4d1e30f
Compare
4d1e30f to
d0a694d
Compare
875184e to
18a53f2
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18a53f2ce8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d0a694d to
97c42a7
Compare
18a53f2 to
171b6d0
Compare
97c42a7 to
4a612ad
Compare
171b6d0 to
e895a68
Compare
|
Authored by an agent, posting via joshlf's account @codex review Please review the current head. Treat earlier reviews of older commits as stale. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add one guide which names the owner of each CI fact and follows data from Cargo manifests and reviewed policy through inventory, planning, GitHub projection, exact execution, and required-check aggregation. Explain how to change features, packages, toolchains, targets, events, baselines, and workflow jobs without creating a second source of truth. Document local audit, inspection, projection, and exact-cell commands. Document the independently planned semver target matrix, its audited three-step job and target-partitioned cache, the exact optional-job required-check bridge, atomic retirement of the old YAML checker, and the platform-specific Cargo-wrapper boundary. Keep the temporary Anneal v1 example matrix clearly separate from the ordinary typed planner because v1 will soon be replaced. Link the guide from CONTRIBUTING, policy comments, and cargo-zerocopy usage so contributors can find the same contract from each entry point. Tests: ci/check_fmt.sh *Authored by an agent, posting via joshlf's account* gherrit-pr-id: G6vtk5f2delygb2de3ctuojmcdbyuolw3
e895a68 to
ea434b5
Compare
|
Authored by an agent, posting via joshlf's account @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea434b5b32
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| redirection, variables, and line continuations. On Windows, run them from a | ||
| POSIX-compatible shell such as Git Bash and replace the | ||
| `./zerocopy/cargo.sh` prefix with `./zerocopy/win-cargo.bat`; selectors and | ||
| options are unchanged. These are not Command Prompt or PowerShell snippets. |
There was a problem hiding this comment.
When a Windows contributor follows this guidance for execute-build-cell, leaving the selector unchanged chooses x86_64-unknown-linux-gnu, which policy classifies as native and build_operations consequently executes via cargo test --target x86_64-unknown-linux-gnu. That requires linking and running Linux test binaries on the Windows host, so replacing only the wrapper with win-cargo.bat is insufficient; direct Windows users to a selected x86_64-pc-windows-msvc cell or qualify the execution samples as Linux-only.
Useful? React with 👍 / 👎.
2 participants
Add one guide which names the owner of each CI fact and follows data
from Cargo manifests and reviewed policy through inventory, planning,
GitHub projection, exact execution, and required-check aggregation.
Explain how to change features, packages, toolchains, targets, events,
baselines, and workflow jobs without creating a second source of truth.
Document local audit, inspection, projection, and exact-cell commands.
Document the independently planned semver target matrix, its audited
three-step job and target-partitioned cache, the exact optional-job
required-check bridge, atomic retirement of the old YAML checker, and
the platform-specific Cargo-wrapper boundary.
Keep the temporary Anneal v1 example matrix clearly separate from the
ordinary typed planner because v1 will soon be replaced.
Link the guide from CONTRIBUTING, policy comments, and
cargo-zerocopy usage so contributors can find the same contract from
each entry point.
Tests: ci/check_fmt.sh
Authored by an agent, posting via joshlf's account
Latest Update: v10 — Compare vs v9
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/G6vtk5f2delygb2de3ctuojmcdbyuolw3 && git checkout -b pr-G6vtk5f2delygb2de3ctuojmcdbyuolw3 FETCH_HEADCheckout
git fetch origin refs/heads/G6vtk5f2delygb2de3ctuojmcdbyuolw3 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/G6vtk5f2delygb2de3ctuojmcdbyuolw3 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.