Repository navigation
fix(GuLoadBalancedAppExperimental): Validate weighting configuration - #2996
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d0da032 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akash1810
force-pushed
the
aa/validate-weighting
branch
from
October 13, 2026 10:41
aba0e79 to
c158c00
Compare
… if a target is set to receive traffic, ensure it has some compute.
akash1810
force-pushed
the
aa/validate-weighting
branch
from
October 14, 2026 08:59
c158c00 to
d0da032
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
If a target is set to receive traffic, ensure it has some compute.
How to test
See added test.
How can we measure success?
Reduced chance of PRs such as guardian/dotcom-rendering#16922 and guardian/dotcom-rendering#16757 which accidentally edited the wrong "minimum" value.
Have we considered potential risks?
None.
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩