Skip to content

fix(cdk): Fail with invalid weighting configuration - #16932

Closed
akash1810 wants to merge 1 commit into
mainfrom
aa/validate-min
Closed

akash1810 wants to merge 1 commit into
mainfrom
aa/validate-min

Conversation

@akash1810

Copy link
Copy Markdown
Member

What does this change?

Validate the weighting configuration: if a target is set to receive traffic, ensure it has some compute.

Why?

This is after #16922 and #16757 accidentally edited the wrong "minimum" value.

How has this change been tested?

N/A.

Validate the weighting configuration: if a target is set to receive traffic, ensure it has some compute.

This is after #16922 and #16757 accidentally edited the wrong "minimum" value.
@akash1810
akash1810 requested a review from a team as a code owner October 13, 2026 06:32
@akash1810 akash1810 added the hotfix Departmental tracking: fix label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:849843506518bf8e865180350b57414ae72cb3286060b1ac3afe7ceeea10c6e6

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:849843506518bf8e865180350b57414ae72cb3286060b1ac3afe7ceeea10c6e6"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-aa-validate-min"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32346"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-ecr.

props;

// If a target is set to receive traffic, ensure it has some compute.
// TODO remove once GuCDK does this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotfix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant