Skip to content

fix(cdk): Fail with invalid weighting configuration #16932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akash1810 wants to merge 1 commit into from
Closed

fix(cdk): Fail with invalid weighting configuration #16932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions dotcom-rendering/cdk/lib/renderingStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,29 @@ export class RenderingCDKStack extends CDKStack {
const { guApp, stage, instanceType, scaling, domainName, ecsProps } =
props;

// If a target is set to receive traffic, ensure it has some compute.
// TODO remove once GuCDK does this.

@akash1810 akash1810 Oct 13, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guardian/cdk#2996

const maybeTargetGroupWeights = ecsProps?.targetGroupWeights;
if (maybeTargetGroupWeights) {
const { ec2: ec2Weight, ecs: ecsWeight } = maybeTargetGroupWeights;
const totalWeight = ec2Weight + ecsWeight;

const ec2Min = scaling.minimumInstances;
const ecsMin = ecsProps.scaling.minimumTasks;

if (ec2Weight > 0 && ec2Min <= 0) {
throw new Error(
`Invalid configuration: EC2 is set to serve traffic (${ec2Weight} of ${totalWeight} requests), but has ${ec2Min} instances.`,
);
}

if (ecsWeight > 0 && ecsMin <= 0) {
throw new Error(
`Invalid configuration: ECS is set to serve traffic (${ecsWeight} of ${totalWeight} requests), but has ${ecsMin} tasks.`,
);
}
}

super(scope, id, {
// Any version of this app should run in the eu-west-1 region
env: { region: 'eu-west-1' },
Expand Down
Loading