Repository navigation
Conversation
This was referenced Sep 25, 2026
An ExternalVolume is an atespace-scoped CSI volume whose lifetime is independent of any actor. It is provisioned from a StorageClass or registers a volume that already exists, carries an immutable access mode, and is removed either manually or when the last actor referencing it is deleted, according to its delete trigger. Deleting the record also deletes the storage. This adds the resource, its Postgres table and store methods, the create/get/list/update/delete RPCs, and kubectl-ate commands. Nothing references a volume yet; actor references arrive separately. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
hajiler
force-pushed
the
shared-volumes/01-actor-volume-status
branch
from
October 13, 2026 15:59
e57907a to
9256686
Compare
hajiler
force-pushed
the
shared-volumes/03-external-volume
branch
from
October 13, 2026 15:59
b68483b to
1c24dc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ExternalVolume: an atespace-scoped CSI volume whose lifetime is independent of any actor (design: go/substrate-shared-volumes, Milestone 1, "Volume identity" Proposal 3).metadata,delete_trigger,access_mode,storage_class_name,capacity,volume_id,volume_type,volume_context,status{state, refs[]}. Storage-level ID issubstrate-<uid>.MANUAL(only an explicit delete removes the volume; default when registering an existing volume) orLAST_ACTOR(removed when the last referencing actor is deleted; default when provisioning). Deleting the record always deletes the storage; a reclaim policy is left as a TODO. AnATESPACEtrigger is left as a TODO.READ_WRITE_ONCE).READ_WRITE_MANYis rejected for now with a TODO; passing the mode to CSICreateVolumeis also a TODO for M2.actor_uid,actor_name, andactiveso references cover paused and suspended actors, not only resumed ones. Nothing writes refs yet; that is PR 4.PENDINGrecord that is cleaned up by deleting it. Delete refuses while any ref exists, honoursDeleteOptionspreconditions, and deletes the storage before the row.ON DELETE RESTRICTfrom atespaces, like tags), store contract tests,kubectl ate {get,create,update,delete} externalvolumewith--delete-triggerand--access-mode.PR 3 of 4, stacked on #8 (
shared-volumes/01-actor-volume-status). Diff against that branch only.Test plan
go test ./cmd/ateapi/internal/controlapi/ ./cmd/ateapi/internal/store/... ./cmd/ateapi/internal/defaults/ ./cmd/kubectl-ate/...go test ./cmd/ateapi/internal/controlapi/functionaltest/(newTestCreateExternalVolume_*,TestUpdateExternalVolume,TestDeleteExternalVolume)cd tools/apitool && go run . validatehack/verify/{codegen,gofmt,boilerplate,postgresql-migrations,golangci-lint}.shhack/verify/proto-fmt.sh(clang-format is not installed locally; please let CI confirm)🤖 Generated with Claude Code