Repository navigation
Conversation
This was referenced Sep 25, 2026
An EmptyDirVolume is an empty host directory at the same path an external volume would be published to, mounted into the sandbox the same way. It lets a golden actor warm up against a placeholder for an external volume it must not mount, so the snapshot's mount table matches the real actor's on both gVisor and microVM. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
hajiler
force-pushed
the
shared-volumes/02-empty-dir-volume
branch
from
October 13, 2026 15:59
26363a0 to
7cd29c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
EmptyDirVolumeto the atelet workload spec: an empty host directory created at the same path an external volume is published to (VolumeHostPath), mounted into the sandbox the same way as an external volume on both gVisor (bind) and microVM (virtio-fs share). It is cleared on every Run/Restore.This is what lets a golden actor warm up against a placeholder for a shared
ExternalVolumeit must not mount, so the snapshot's mount table matches the real actor's. Using a durable dir for that (as the POC did) puts the placeholder at a different source path, which the design doc identified as breaking microVM restores.PR 2 of 4 for shared external volumes, Milestone 1 (independent of #8; #11 depends on it).
Test plan
go test ./cmd/atelet/... ./internal/ocispec/...(newTestResetEmptyDirClearsPreviousContents, extended mount mapping tests)go build ./...,hack/verify/codegen.sh🤖 Generated with Claude Code