Skip to content

[Vulcan] Clarify XLS palette support in colorUnpack documentation - #332

Merged
iliaal merged 1 commit into
masterfrom
docs/color-unpack-xls-support
Oct 21, 2026
Merged

iliaal merged 1 commit into
masterfrom
docs/color-unpack-xls-support

Conversation

@iliaal

@iliaal iliaal commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Summary

Correct the ExcelBook::colorUnpack() summary, which incorrectly says the method is XLSX-only. It also decodes XLS palette colors, as the detailed return documentation on the same method already explains. No executable code, signatures or test coverage changed.

Evidence

  • Existing regression 238 covers XLS black/red/palette index 63 and XLSX packed colors, while rejecting unmapped XLS colors.
  • The native implementation calls xlBookColorUnpack for either workbook format and handles unmapped colors.

Validation

  • Current default and open PRs inspected. This single-line change is disjoint from [Vulcan] Clarify workbook text encoding #330 (README) and [Vulcan] Correct clearing method return documentation #331 (other API reference files).
  • Exact live API-reference blob verified; comment-stripped PHP content is byte-identical before/after, and whitespace checks pass.
  • Existing regression inspected, not run locally: PHP/phpize are unavailable in the local environment. No local native build, PHP lint, full PHPT suite or performance claim.
  • Remote CI will be checked for the exact published head; results recorded separately.

iliaal commented Oct 20, 2026

Copy link
Copy Markdown
Owner Author

Validation for final head 5152a80ce39f70ba3c6426eab2fc105237db07cc:

  • Tests: all 15 jobs succeeded, including Composer, stub freshness, PIE, PHP 8.1–8.6, LibXL versions, ZTS and ASAN lanes.
  • Windows Build: all 21 executed jobs succeeded (matrix generation and 20 build/test lanes). Release attachment was intentionally skipped for the PR.
  • Retrieved and reviewed successful job logs. PHPT summaries report zero failures. PHP 8.4 with LibXL 5.2.0.1 reports 252 passed / 9 skipped; platform, version and licensed-feature skips vary by lane and are not counted as passes.
  • Remote file content matches the intended single PHPDoc-line edit. Executable PHP remains unchanged. Local PHP/native checks remain unavailable as disclosed above.

@iliaal
iliaal merged commit 847875b into master Oct 21, 2026
37 checks passed
@iliaal
iliaal deleted the docs/color-unpack-xls-support branch October 21, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant