Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Document the existing moveSheet() lifetime contract: a successful move invalidates every sheet wrapper and sheet-owned child, including unchanged-position sheets. Callers must re-fetch; failed moves leave wrappers usable, and workbook fonts/formats survive.
README example and ExcelBook reference now explain this. New test 259 covers XLS/XLSX sheet wrappers, XLSX filter children, failed moves, retained workbook objects and refetched data. Runtime code is unchanged; no changelog entry for this documentation/test-only change.
Validation
Limits
Local build used retained official headers/library with direct compiler invocation, not a fresh phpize/configure install. Seven license/platform skips are not passes. No local Windows, ZTS, sanitizer or performance claim. No runtime behavior changed.