Repository navigation
Conversation
Provide an owner-scoped path for pointer-stable kernels that cannot stay inside CUDA graph regions. Preserve eager A/B mode and validate recorded storage contracts in debug builds.
Route persistent direct-task, MDP, and manager launches through environment-owned caches so uncapturable stages avoid eager marshalling on every kernel. Keep transient allocations eager.
Gate replay for validated pointer-stable articulation, rigid-object, derived-state, and actuator paths. Leave the feature disabled by default while broader workload coverage matures.
Add a reproducible mixed-kernel matrix and completed-step timing controls to compare eager launch, recorded replay, dynamic setters, and graph composition across launch and thread scales.
hujc7
force-pushed
the
jichuanh/warp-launch-record-replay
branch
from
July 16, 2026 08:41
2c874fe to
fbe99e6
Compare
Runtime manager-term updates can replace scalar or callable inputs that are baked into captured graphs and recorded launches. Invalidate the owner caches only when a curriculum actually writes a new value.
8 tasks done
6 of 8 tasks
Collaborator
Author
|
Superseded by #6611, which now absorbs everything from this PR on top of the simplified #6607 frontend: the owner-scoped |
This was referenced Jul 21, 2026
kellyguo11
added a commit
that referenced
this pull request
Jul 24, 2026
…asks (#5504) ## Review Map - A stacked PR’s page shows the cumulative diff of its dependency chain; the "Exact changes" link pins that PR’s own commit range. - SHA links can go stale after a branch update; the copy on #5504 is refreshed first. | PR | Status | Depends on | Exact changes | |---|---|---|---| | 📌 #5504 Part 1: frontend bridge (stable ids on the warp runtime) |  | — | — | | #6607 Part 2: mask-first frontend (draft) |  | #5504 | [link](https://github.com/isaac-sim/IsaacLab/pull/6607/changes/00ae695ac63e67ca678b91a837d3737529d2ec91..f68d03f40854b31a36063c5068f2933d32ea5db9) | | #6646 Part 3: scene reset mask-native + capture-ready (draft, base rewritten — pending rebase onto #6607) |  | #6607 | [link](https://github.com/isaac-sim/IsaacLab/pull/6646/changes/4360622bde446c52c3fc85924639f9d1119d6e95..6d49e32f11e15894a4a0e49161a356ec79679ac6) | | #6580 Part 4: OVPhysX backend (draft) |  | #5504 | [link](https://github.com/isaac-sim/IsaacLab/pull/6580/changes/fc37fa65ad95d1ac6e3f32e721329ef715899d37..716cef20979ca6c578a6e595812291c7b1a282fc) | | #6611 Part 5: persistent-launch speedups (draft, absorbs #6551) |  | #6646 | [link](https://github.com/isaac-sim/IsaacLab/pull/6611/changes/6d49e32f11e15894a4a0e49161a356ec79679ac6..6e3da794215da03745a9bc8d35790e22262b099a) | ## 1. Summary - `--frontend {torch,warp}` on the shared RL CLI (train **and play**) runs **stable** task ids on the warp runtime — no duplicated configs, no parallel warp task registrations at all (end state pinned by test). The `rlinf` integration constructs environments inside the external framework and is not frontend-routable (known limitation). - **1.24–1.70× faster end-to-end** than torch on the same tasks, identical Newton physics (§3.1). - Manager-based: `WarpFrontend` adapts the stable cfg in place; MDP twins resolve by name on the mirrored experimental package tree — deterministic, registration-free, missing twins reported in one aggregated failure. - Direct: the stable registration declares its warp class via `warp_entry_point`; only the env class swaps, the cfg is shared. - Stable observation-noise cfgs (constant/uniform/gaussian) swap to warp-native twins during adaptation; cfgs without a twin (class-based noise models, customized funcs, tensor-valued params) are a hard error instead of silently dropping noise. The warp observation manager rejects non-warp noise cfgs and plumbs the shared per-env RNG state. - Plus: warp adapters for the material/mass randomization startup events; `isaaclab_tasks_experimental` mirrors the stable `core/<task>` layout; `Metrics/success_rate` restored under warp. ## 2. Migration map | Retired | Replacement | |---|---| | `Isaac-{Cartpole,Humanoid,Ant}-Warp-v0`, `Isaac-Reach-Franka-Warp-v0` (+`-Play`) | stable id + `--frontend warp presets=newton_mjwarp` | | `Isaac-Velocity-Flat-<Robot>-Warp-v0` (+`-Play`), all robots | stable id + `--frontend warp presets=newton_mjwarp` | | `Isaac-{Cartpole,Ant,Humanoid}-Direct-Warp-v0`, `Isaac-Reorient-Cube-Allegro-Direct-Warp-v0` | stable id + `--frontend warp presets=newton_mjwarp` (via `warp_entry_point`) | ## 3. Test plan - [x] Merged current `develop`; `./isaaclab.sh -f` clean on all files. - [x] Re-merged develop (task-id catalog update #6606, entrypoints refactor); environments catalog regenerated; conversion sweep + warp smokes (`Isaac-Velocity-Flat-UnitreeGo2`, `Isaac-Cartpole-Direct`) re-run green; pre-commit clean on all files. - [x] 142 focused tests: frontend units, cfg-conversion sweep over every covered stable id, no-warp-registrations end-state pin, shared-CLI tests. - [x] 5-iteration RSL-RL trainings exit clean (`Training time:` present, no traceback): `Isaac-Cartpole` (torch); `Isaac-Cartpole`, `Isaac-Humanoid`, `Isaac-Cartpole-Direct`, `Isaac-Ant-Direct`, `Isaac-Velocity-Flat-AnymalD`, `Isaac-Velocity-Flat-H1` (warp; randomization events active); `Isaac-Reorient-Cube-Allegro-Direct` (warp). `Metrics/success_rate` reported under warp. ### 3.1 Frontend A/B benchmark Same stable task id and cfg on both sides, `presets=newton_mjwarp` on **both** (identical Newton physics — only `--frontend` differs); rsl_rl, 4096 envs, 300 iterations, headless, one L40 per run, single run per cell. Metric: rsl_rl `Training time:` — learn-loop wall-clock (env stepping + PPO update; warp includes its one-time CUDA-graph capture). PPO-update cost is common to both, so the env-pipeline gain exceeds the end-to-end ratio. | Task | torch | warp | end-to-end | final reward (torch / warp) | |---|---|---|---|---| | `Isaac-Cartpole` | 58.2 s | 39.7 s | 1.46× | 4.95 / 4.95 | | `Isaac-Humanoid` | 162.0 s | 110.5 s | 1.47× | 149.1 / 179.8 | | `Isaac-Ant` | 109.8 s | 64.5 s | 1.70× | 82.1 / 77.1 | | `Isaac-Velocity-Flat-AnymalD` | 162.4 s | 130.7 s | 1.24× | 20.3 / 21.4 | ## 4. Out of scope / follow-ups - No video-recorder plumbing on warp envs; rough terrain blocked on Warp `TerrainImporter` APIs; no twins for IK/OSC actions, `height_scan`, or Digit/Spot-specific terms. - OVPhysX support for the warp frontend prepared as a follow-up PR (physics gate widening + backend data-parity test). - Candidate refactor: fold the ~300 lines of converged plumbing shared by `DirectRLEnvWarp` and stable `DirectRLEnv` into a common base. --------- Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
matthewtrepte
pushed a commit
to matthewtrepte/IsaacLab
that referenced
this pull request
Aug 4, 2026
…asks (isaac-sim#5504) ## Review Map - A stacked PR’s page shows the cumulative diff of its dependency chain; the "Exact changes" link pins that PR’s own commit range. - SHA links can go stale after a branch update; the copy on isaac-sim#5504 is refreshed first. | PR | Status | Depends on | Exact changes | |---|---|---|---| | 📌 isaac-sim#5504 Part 1: frontend bridge (stable ids on the warp runtime) |  | — | — | | isaac-sim#6607 Part 2: mask-first frontend (draft) |  | isaac-sim#5504 | [link](https://github.com/isaac-sim/IsaacLab/pull/6607/changes/00ae695ac63e67ca678b91a837d3737529d2ec91..f68d03f40854b31a36063c5068f2933d32ea5db9) | | isaac-sim#6646 Part 3: scene reset mask-native + capture-ready (draft, base rewritten — pending rebase onto isaac-sim#6607) |  | isaac-sim#6607 | [link](https://github.com/isaac-sim/IsaacLab/pull/6646/changes/4360622bde446c52c3fc85924639f9d1119d6e95..6d49e32f11e15894a4a0e49161a356ec79679ac6) | | isaac-sim#6580 Part 4: OVPhysX backend (draft) |  | isaac-sim#5504 | [link](https://github.com/isaac-sim/IsaacLab/pull/6580/changes/fc37fa65ad95d1ac6e3f32e721329ef715899d37..716cef20979ca6c578a6e595812291c7b1a282fc) | | isaac-sim#6611 Part 5: persistent-launch speedups (draft, absorbs isaac-sim#6551) |  | isaac-sim#6646 | [link](https://github.com/isaac-sim/IsaacLab/pull/6611/changes/6d49e32f11e15894a4a0e49161a356ec79679ac6..6e3da794215da03745a9bc8d35790e22262b099a) | ## 1. Summary - `--frontend {torch,warp}` on the shared RL CLI (train **and play**) runs **stable** task ids on the warp runtime — no duplicated configs, no parallel warp task registrations at all (end state pinned by test). The `rlinf` integration constructs environments inside the external framework and is not frontend-routable (known limitation). - **1.24–1.70× faster end-to-end** than torch on the same tasks, identical Newton physics (§3.1). - Manager-based: `WarpFrontend` adapts the stable cfg in place; MDP twins resolve by name on the mirrored experimental package tree — deterministic, registration-free, missing twins reported in one aggregated failure. - Direct: the stable registration declares its warp class via `warp_entry_point`; only the env class swaps, the cfg is shared. - Stable observation-noise cfgs (constant/uniform/gaussian) swap to warp-native twins during adaptation; cfgs without a twin (class-based noise models, customized funcs, tensor-valued params) are a hard error instead of silently dropping noise. The warp observation manager rejects non-warp noise cfgs and plumbs the shared per-env RNG state. - Plus: warp adapters for the material/mass randomization startup events; `isaaclab_tasks_experimental` mirrors the stable `core/<task>` layout; `Metrics/success_rate` restored under warp. ## 2. Migration map | Retired | Replacement | |---|---| | `Isaac-{Cartpole,Humanoid,Ant}-Warp-v0`, `Isaac-Reach-Franka-Warp-v0` (+`-Play`) | stable id + `--frontend warp presets=newton_mjwarp` | | `Isaac-Velocity-Flat-<Robot>-Warp-v0` (+`-Play`), all robots | stable id + `--frontend warp presets=newton_mjwarp` | | `Isaac-{Cartpole,Ant,Humanoid}-Direct-Warp-v0`, `Isaac-Reorient-Cube-Allegro-Direct-Warp-v0` | stable id + `--frontend warp presets=newton_mjwarp` (via `warp_entry_point`) | ## 3. Test plan - [x] Merged current `develop`; `./isaaclab.sh -f` clean on all files. - [x] Re-merged develop (task-id catalog update isaac-sim#6606, entrypoints refactor); environments catalog regenerated; conversion sweep + warp smokes (`Isaac-Velocity-Flat-UnitreeGo2`, `Isaac-Cartpole-Direct`) re-run green; pre-commit clean on all files. - [x] 142 focused tests: frontend units, cfg-conversion sweep over every covered stable id, no-warp-registrations end-state pin, shared-CLI tests. - [x] 5-iteration RSL-RL trainings exit clean (`Training time:` present, no traceback): `Isaac-Cartpole` (torch); `Isaac-Cartpole`, `Isaac-Humanoid`, `Isaac-Cartpole-Direct`, `Isaac-Ant-Direct`, `Isaac-Velocity-Flat-AnymalD`, `Isaac-Velocity-Flat-H1` (warp; randomization events active); `Isaac-Reorient-Cube-Allegro-Direct` (warp). `Metrics/success_rate` reported under warp. ### 3.1 Frontend A/B benchmark Same stable task id and cfg on both sides, `presets=newton_mjwarp` on **both** (identical Newton physics — only `--frontend` differs); rsl_rl, 4096 envs, 300 iterations, headless, one L40 per run, single run per cell. Metric: rsl_rl `Training time:` — learn-loop wall-clock (env stepping + PPO update; warp includes its one-time CUDA-graph capture). PPO-update cost is common to both, so the env-pipeline gain exceeds the end-to-end ratio. | Task | torch | warp | end-to-end | final reward (torch / warp) | |---|---|---|---|---| | `Isaac-Cartpole` | 58.2 s | 39.7 s | 1.46× | 4.95 / 4.95 | | `Isaac-Humanoid` | 162.0 s | 110.5 s | 1.47× | 149.1 / 179.8 | | `Isaac-Ant` | 109.8 s | 64.5 s | 1.70× | 82.1 / 77.1 | | `Isaac-Velocity-Flat-AnymalD` | 162.4 s | 130.7 s | 1.24× | 20.3 / 21.4 | ## 4. Out of scope / follow-ups - No video-recorder plumbing on warp envs; rough terrain blocked on Warp `TerrainImporter` APIs; no twins for IK/OSC actions, `height_scan`, or Digit/Spot-specific terms. - OVPhysX support for the warp frontend prepared as a follow-up PR (physics gate widening + backend data-parity test). - Candidate refactor: fold the ~300 lines of converged plumbing shared by `DirectRLEnvWarp` and stable `DirectRLEnv` into a common base. --------- Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Summary
isaaclab: adds owner-scopedWarpLaunchCache, eager/replay A/B mode, debug pointer/layout validation, and a reproducible mixed-kernel benchmark.isaaclab_experimental: converts persistent direct, manager, and MDP launch sites while retaining eager execution for transient allocations.isaaclab_newton: adds default-off replay for validated pointer-stable articulation, rigid-object, derived-state, and actuator paths.isaaclab_tasks_experimental: converts Cartpole, locomotion, Allegro in-hand, and manager-task hot paths.The counterbalanced actual-environment grid measured Ant and Allegro Direct at
256, 1,024, 4,096, and 16,384 environments on four L40s:
1.06372x(+6.372%, descriptive 95% CI1.03690–1.09124)Per-step-synchronized diagnostics exposed roughly
65–106 us/stepof removedhost launch overhead. The normal pipeline hides that saving behind queued GPU
work in saturated cases. The isolated launch ablation independently confirms
that graphs remain fastest for capture-safe regions and replay removes most
Warp Python marshalling from persistent uncaptured calls.
2. Design notes
set_dim()path.3. Test plan
git diff --check.4. Follow-ups
Type of change
Checklist
./isaaclab.sh -f.CONTRIBUTORS.md.