Repository navigation
Conversation
Every test job either names a package with a positive filter-pattern or, for the core jobs, excludes anything matching isaaclab_. isaaclab_ppisp matched neither, so all four of its test files were collected by no job and had never run. Replaying the filter logic over the tree, test files matched by no job goes from four to zero, so every file under source/ is now claimed by exactly one job. The suite is green as it stands: 26 passed, 1 skipped, 4.6s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
source/isaaclab_ppisp/had no CI job. All four of its test files were collected by nothing and had never run.Every job either names a package with a positive
filter-pattern, or — for the core jobs — passesnot isaaclab_, whichrun_tests.shconverts into an exclude onisaaclab_. A package matching neither form runs nowhere, silently: no job errors, no "0 tests collected" warning, because other jobs still collect plenty.source/is now claimed by a job.Same gap and same fix as
isaaclab_experimentalin #6900; this was called out there as out of scope.Test plan:
pytest source/isaaclab_ppisp/test/— 26 passed, 1 skippeduv run isaaclab -fclean