Repository navigation
[Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ooctipus
merged 24 commits into
isaac-sim:develop
from
StafaH:perf/camera-perf-07b-hot-path
Sep 30, 2026
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2300758
Skip wrench composer resets while inactive
StafaH f0fb3fb
Remove redundant solver reset from Newton physics step
StafaH bc225bf
Use elapsed time for Newton body COM acceleration
StafaH 5bd37c1
Read back clamped joint defaults only when logged
StafaH e890cdf
Remove host syncs and redundant kernels from manager hot paths
StafaH 92175d9
Trim sensor, marker, and renderer hot-path overhead
StafaH f6b9771
Merge branch 'perf/hot-path-7b-newton' into perf/camera-perf-07b-hot-…
StafaH 5ccec99
Merge branch 'perf/hot-path-7b-managers' into perf/camera-perf-07b-ho…
StafaH c833086
Remove host syncs from task hot paths and RL wrappers
StafaH 2792d5f
Merge branch 'perf/hot-path-7b-sensors' into perf/camera-perf-07b-hot…
StafaH 0c5612a
Use elapsed time for OVPhysX rigid-object COM acceleration
StafaH 8eccb93
Merge branch 'perf/hot-path-7b-tasks' into perf/camera-perf-07b-hot-path
StafaH 7b5b894
Merge branch 'develop' of https://github.com/isaac-sim/IsaacLab into …
StafaH 282a75b
Trim redundant hot-path regression tests
StafaH ec65628
Address hot-path review feedback and consolidate tests
StafaH a71c9af
Centralize sampling from named event ranges
StafaH e8a0e12
Require noise callbacks to preserve their inputs
StafaH cd13a32
Keep noise configuration docs concise
StafaH e81da34
Trim redundant host-sync comments
StafaH e300905
Merge branch 'develop' into perf/camera-perf-07b-hot-path
StafaH ea03b65
Remove sync-focused curriculum and velocity command tests
StafaH dc82bb9
Trim sync, RNG, and private-state test assertions
StafaH 1ca362a
Restore contact force magnitude helper name
StafaH e9d4425
Fix hot-path PR test failures and benchmark cache permissions
StafaH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
39 changes: 39 additions & 0 deletions
39
source/isaaclab/changelog.d/perf-hot-path-7b-managers.major.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added :func:`~isaaclab.utils.math.sample_uniform_from_ranges` to sample named components with | ||
| shared, bounded caching of device bounds. Core and Lift event terms now use this sampler instead | ||
| of maintaining separate tensor-cache helpers. | ||
|
|
||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Required noise functions and models configured through | ||
| :class:`~isaaclab.utils.noise.NoiseCfg` and :class:`~isaaclab.utils.noise.NoiseModelCfg` | ||
| to leave their input unchanged. :class:`~isaaclab.managers.ObservationManager` now calls | ||
| them without a defensive input copy. Custom callbacks using in-place operations must | ||
| clone their input first (for example, ``data.clone().add_(bias)``) or use out-of-place | ||
| operations (``data + bias``). Returning the unchanged input or a view remains supported; | ||
| the manager still protects borrowed outputs during subsequent processing. | ||
|
|
||
| * Changed episode logging in :class:`~isaaclab.managers.CommandTerm`, | ||
| :class:`~isaaclab.managers.TerminationManager`, :class:`~isaaclab.managers.CurriculumManager`, | ||
| :class:`~isaaclab.envs.mdp.UniformPoseCommand`, :class:`~isaaclab.envs.mdp.UniformPose2dCommand` and | ||
| :class:`~isaaclab.envs.mdp.survival_success_rate` to report 0-d device tensors instead of Python floats, | ||
| matching :class:`~isaaclab.managers.RewardManager`, so resets no longer synchronize the stream. Code that | ||
| reads these ``extras["log"]`` entries as floats should call ``float()`` or ``.item()`` on them. | ||
| * Removed per-step host synchronizations from the heading control of | ||
| :class:`~isaaclab.envs.mdp.UniformVelocityCommand` and from | ||
| :class:`~isaaclab.envs.mdp.actions.task_space_actions.DifferentialInverseKinematicsAction`. | ||
| * Cached the device range tensors of the root-state, nodal-state, push and center-of-mass event terms by | ||
| value instead of uploading them on every call. | ||
| * Batched the per-term updates of :class:`~isaaclab.managers.RewardManager`, and skipped the defensive copy | ||
| before noise callbacks and after delay buffers in :class:`~isaaclab.managers.ObservationManager`. | ||
| * Shifted :class:`~isaaclab.utils.buffers.CircularBuffer` histories of small frames in two kernels | ||
| regardless of the history length. | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed :class:`~isaaclab.envs.mdp.reset_root_state_uniform` ignoring the ``pose_range`` and ``velocity_range`` | ||
| passed at call time, including curriculum updates, in favor of the ranges present at construction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed :meth:`~isaaclab.utils.wrench_composer.WrenchComposer.reset` to return without launching work | ||
| when the composer is inactive, removing the per-step buffer clears for rigid objects and collections | ||
| that apply no external wrench. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed sensors with ``debug_vis=True`` to refresh their buffers lazily from the debug | ||
| visualization callback instead of on every :meth:`~isaaclab.sensors.SensorBase.update`. | ||
| Custom sensors must refresh outdated buffers (for example through ``data``) in their | ||
| ``_debug_vis_callback`` before reading internal data. | ||
| * Skipped ray-caster drift sampling on reset when ``drift_range`` and ``ray_cast_drift_range`` | ||
| are zero, and uploaded the ray-cast drift ranges to the device only when they change. | ||
| * Changed :meth:`~isaaclab.markers.VisualizationMarkers.visualize` to return without validating | ||
| or processing inputs when no visualizer backend is active, such as in headless runs. | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Cleared previously sampled ray-caster drift on reset when its configured range was changed to zero. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.