Repository navigation
[Core] Inline launch-stack helpers that only restate or forward #8111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ooctipus
merged 3 commits into
isaac-sim:develop
from
ooctipus:octi/launch-helper-cleanup
Sep 29, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
source/isaaclab/changelog.d/launch-helper-cleanup.major.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Changed ``--viz none`` to parse to an empty list instead of ``None``, so ``args_cli.visualizer is None`` | ||
| means no ``--viz`` was passed and ``[]`` means all visualizers are disabled. The ``visualizer_explicit`` and | ||
| ``visualizer_disable_all`` launcher arguments are removed; check ``args_cli.visualizer`` instead. | ||
| * Changed :func:`~isaaclab.app.launch_simulation` to also detect a ``newton_rtx`` visualizer listed in | ||
| ``visualizer_cfgs``, so the OVRTX runtime starts and the Kit conflict check applies. | ||
|
|
||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added ``launcher_type`` to :class:`~isaaclab.physics.PhysicsCfg` and :class:`~isaaclab.renderers.RendererCfg`, | ||
| defaulting to ``None`` for configs whose runtime needs no launcher. | ||
|
|
||
| Removed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Removed ``SettingsManager.instance()``. Use :func:`~isaaclab.app.get_settings_manager`. | ||
| * **Breaking:** Removed ``SettingsManager.set_bool``, ``set_int``, ``set_float``, and ``set_string``. Use | ||
| :meth:`~isaaclab.app.SettingsManager.set`, which dispatches on the value type. | ||
| * **Breaking:** Removed ``isaaclab.app.make_physics_cfg``. Select the backend with the ``physics`` launcher | ||
| argument of :func:`~isaaclab.app.launch_simulation`, or construct the physics config directly. | ||
| * **Breaking:** Removed ``isaaclab.app.logging_utils.resolve_python_logging_level``. | ||
| :func:`~isaaclab.app.launch_simulation` applies the ``--verbose`` / ``--info`` level itself. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning · Api — Public symbols removed without deprecation window
SettingsManager.instance, the typedset_bool/set_int/set_float/set_stringsetters,isaaclab.app.make_physics_cfg, andlogging_utils.resolve_python_logging_levelare deleted outright, andsim_launcher.fuse_kit_argsloses its old import path. Repository rules require a prior deprecation and migration path before removing a public API. Keep thin forwarders that emitDeprecationWarningfor one release, then delete.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional, per the maintainer's policy for this refactor series: APIs outside public config and MDP terms are removed without a deprecation window, and each removal is listed as Breaking with its replacement in the changelog.