[hujc7]

Summary

Backports three develop PRs to release/3.0.0, in merge order:

1. [Changelog] Compile changelog fragments with towncrier and keep uv.lock in sync #8118 — towncrier changelog tooling
2. [Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105 — camera hot-path cleanup [7B/7]
3. [Docs] Use uv CLI for Windows documentation builds #8179 — uv CLI for Windows docs builds

The automatic backport failed for #8118 and #8105. For #8179, this supersedes the bot's draft:

• [Backport] PR #8179 to release/3.0.0 #8209 — bot draft backport of [Docs] Use uv CLI for Windows documentation builds #8179

Once merged, the nightly compiles release/3.0.0 again: it skips release branches without tools/changelog/towncrier.toml.

Description

Each PR is cherry-picked with -x; every code file matches its source patch. Release-specific changes:

1. [Changelog] Compile changelog fragments with towncrier and keep uv.lock in sync #8118 (ee99db6a820)
   • Each CHANGELOG.rst conflict resolved as the marker line above the release entries.
   • uv.lock unchanged: release's local package pins already match their pyproject.toml.
   • The bot failed here because uv.lock pushed its conflict context past the 1.5M-character inference limit.
2. [Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105 (cd917691992)
   • Drops the .github/workflows/build.yaml hunk: it edits the performance-smoke job, which release/3.0.0 does not have. The bot's validation rejected this omission.
   • Splits its 10 old-format fragments into the new format with cli.py's split_legacy, keeping all 34 bullets; [Changelog] Compile changelog fragments with towncrier and keep uv.lock in sync #8118's check rejects the old format.
3. [Docs] Use uv CLI for Windows documentation builds #8179 (c1a8bfa50b5)
   • Deletes docs/make.bat; release held an older copy.
   • Splits its fragment the same way.
   • Release's docs/_redirect/index.html still hardcodes ./main/ ([CI] Prepare develop as repository and docs default #7767 is not on this branch), so isaaclab --docs_multi writes that redirect unchanged, as release's make multi-docs does.

Type of change

• Release backport, carrying [Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105's breaking change (isaaclab major bump)
• New feature, bug fix and documentation update from the source PRs

Validation

1. cli.py check release/3.0.0 passes.
2. tools/changelog tests: 18 passed.
3. pre-commit over the range passes.
4. cli.py compile on a scratch copy of this branch:
   • 9 packages bumped, including isaaclab 25.1.0 → 26.0.0 and isaaclab_tasks_experimental 0.0.1 → 1.0.0
   • every fragment consumed, only its outputs staged
   • uv.lock changed in version lines only
5. Runtime coverage for [Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105 and [Docs] Use uv CLI for Windows documentation builds #8179 is left to CI.

Release backport

This PR targets the release branch; no additional backport is needed.

Checklist

• I have read and understood the contribution guidelines
• I have run the pre-commit checks on the changed files
• I have made corresponding changes to the documentation (carried from the source PRs)
• My changes generate no new warnings
• I have validated the changed behavior with focused coverage (source PRs' tests carried unchanged)
• I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (carried from the source PRs; [Camera] Remove remaining hot-path host syncs and overhead [7B/7] #8105 and [Docs] Use uv CLI for Windows documentation builds #8179 converted to the new format)
• I have added my name to the CONTRIBUTORS.md or my name already exists there

[hujc7]

run-ci

[greptile-apps]

Confidence Score: 4/5

[Medium risk] Backport of changelog tooling migration and performance optimizations.

The PR should not merge until the multi-version documentation redirect points to the selected built ref.

Findings

1.  Redirect targets the wrong version ▶
2.  Marker content is silently discarded ▶
3.  Orphan paragraphs pass validation ▶

Summary

The backport migrates package changelogs to Towncrier and uv, adds a cross-platform documentation CLI, and carries simulation hot-path changes across managers, sensors, backends, and tasks.

• The new multi-version CLI does not update the checked-in redirect to its selected documentation ref.
• The fragment gate leaves two actionable validation gaps.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  F[Package changelog fragments] --> C[cli.py check]
  C --> N[Nightly compile]
  N --> T[Towncrier release notes]
  N --> V[Package version bumps]
  V --> L[uv.lock refresh]
  D[isaaclab --docs_multi] --> B[Built versioned docs]
  B --> R[Root redirect]

Loading

_{Reviews (1) · Last reviewed commit: "[Docs] Use uv CLI for Windows documentat..."}

[greptile-apps]

Redirect targets the wrong version

When isaaclab --docs_multi builds the default v3.0.0-EA ref or a ref selected through DOCS_DEFAULT_REF, this replacement does nothing: the checked-in template contains ./main/index.html, not __DOCS_DEFAULT_REF__. The target check can pass while the generated redirect still sends readers to main, or to a missing page if main was not built. The existing Makefile rewrites the actual URL; the new test instead uses a template with the placeholder.

[greptile-apps]

Marker content is silently discarded

The gate accepts a nonempty .skip, .minor, or .major file without checking its contents. These files are meant to be empty, and Towncrier hides their contents, so a contributor who puts release-note text in one gets a passing check but loses that note during compilation. Reject nonempty markers to make the mistake visible.

[greptile-apps]

Orphan paragraphs pass validation

A fragment can start with an indented paragraph and place a bullet later: the first check finds that bullet, while the second accepts the earlier indented line as a continuation. The PR gate therefore accepts content that is not a bullet list, leaving malformed RST for the nightly changelog. Only accept an indented continuation after a bullet.

[isaaclab-review-bot]

Isaac Lab Review Bot

The backport coherently integrates towncrier, hot-path optimizations, and the uv-backed documentation CLI, but it also introduces several immediate compatibility breaks without deprecation bridges. The release-specific multi-version redirect and marker-fragment validation also need correction, and the Windows workflow should follow the repository’s action-pinning convention.

• Design and architecture: The changelog check/compiler split, cached range tensors, batched reward updates, and cached ANYmal symmetry tables are coherent. However, the hot-path design transfers ownership obligations from framework boundaries to extension implementations: noise callbacks must now preserve inputs, and sensor debug callbacks must refresh buffers themselves. Those shifts affect established extension contracts and need a compatibility transition rather than immediate enforcement.
• API: The additive isaaclab --docs_multi, command_build_docs(multi_version=...), and sample_uniform_from_ranges APIs are consistent with surrounding interfaces. Existing API behavior changes are not additive: manager reset and logging values switch from floats to tensors, task index attributes and resolve_actuated_tendons switch from lists to tensors, headless marker visualization stops validating inputs, noise callbacks lose defensive copies, and sensor debug callbacks acquire a new refresh obligation.
• Compatibility and deprecation: Breaking changes: docs/make.bat is removed without a forwarding wrapper; manager reset and task logging values change from Python floats to device tensors; configured noise callbacks now receive un-cloned observation storage; headless VisualizationMarkers.visualize calls no longer enforce the prior validation contract; external SensorBase debug-visualization implementations must refresh their own buffers; and public task index attributes plus resolve_actuated_tendons change from lists to tensors. Changelog and documentation migration notes are present, but none of these changes has the required functional old-contract bridge, targeted warning, removal guidance, and transition coverage.
• Implementation: The changelog rollback/staging flow, lock-pin checks, docs build cleanup, drift caching, reward batching, and circular-buffer shift paths were traced. Two concrete issues remain: the release branch’s redirect template hardcodes ./main/, so replacing __DOCS_DEFAULT_REF__ is ineffective while the gate checks a different default target; and marker fragments matching .skip, .minor, or .major are accepted even when non-empty, allowing hidden content to be silently discarded during compilation.
• Style consistency: The Python naming, docstrings, helper placement, and surrounding implementation patterns are generally consistent. The new Windows documentation workflow uses the floating actions/checkout@v6 tag despite adjacent workflows—and the setup-uv step in the same file—pinning actions to reviewed commit SHAs. Pin checkout consistently.
• Test quality: The changed tests provide distinct coverage for root-state range edits, noise ownership, reward batching and partial reset, drift clearing, lazy sensor visualization, marker behavior, circular-buffer shifts, renderer channel handling, and changelog compilation. Several tests currently codify the immediate breaking contracts rather than covering deprecation transitions. The docs redirect test supplies a placeholder template and therefore misses the release branch’s hardcoded ./main/ template, while the changelog tests do not reject non-empty marker files.

Significant concerns. Posted 9 actionable findings inline.

Automated review; human maintainers own approval decisions.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Windows docs entry point removed outright

Deleting docs/make.bat removes the documented make.bat current-docs and make.bat multi-docs entry points immediately; updating docs/README.md and the contribution guide is migration guidance, not a transition. Existing Windows scripts and contributor muscle memory break without notice. Keep a thin batch wrapper that forwards both targets to isaaclab --docs / --docs_multi and prints replacement and removal guidance for the deprecation window.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Reset metrics change from floats to tensors

CommandTerm.reset changes its annotated and actual return from dict[str, float] to device tensors, and the same swap lands in TerminationManager.reset, CurriculumManager.reset and the task extras["log"] writers. Consumers that serialize or apply float-only arithmetic to these values break with no compatibility path. Retain the scalar contract during deprecation and expose the sync-free tensor metrics under a separate key or API.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Noise callbacks lose defensive input copy

Dropping obs.clone() requires every configured NoiseCfg.func/NoiseModelCfg to leave its input untouched. An existing in-place callback (previously safe, and not forbidden by the old docstring) now writes into term-owned or asset-owned storage. The changelog marks this Breaking, but no transition exists: no warning on the old path and no opt-out. Keep the copy for the deprecation window while warning on mutation, or gate zero-copy behind explicit opt-in.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Headless visualize skips documented input validation

Returning before normalization when self._backends is empty means mismatched shapes and all-None calls now succeed silently in headless runs, although the docstring still documents ValueError for both. The same call then raises once a backend is active, making the failure contract depend on rendering configuration. Keep the inexpensive validation ahead of the backend early return and skip only the backend dispatch.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Debug visualization refresh moved to subclasses

update() no longer refreshes outdated buffers when debug_vis is enabled, so every sensor overriding the protected _debug_vis_callback must now call _update_outdated_buffers() itself. In-repo sensors were updated, but external sensors silently draw stale data with no warning or error. Preserve the eager refresh for the deprecation window, or refresh once before dispatching callbacks from the visualization registry.

[isaaclab-review-bot]

🟡 Warning · Compatibility — Public index attributes change to tensors

resolve_actuated_tendons now returns a torch.Tensor instead of list[int], and the changelog documents the same switch for the public actuated_dof_indices, finger_bodies, finger_wrench_bodies, arm_joint_ids and finger_joint_ids attributes. Callers using list equality, membership, concatenation or serialization break immediately; a .tolist() note is migration guidance, not a bridge. Keep the list contracts and cache device tensors privately until a deprecation cycle completes.

[isaaclab-review-bot]

🔵 Suggestion · Style Consistency — Checkout action not pinned to SHA

Every other workflow pins actions to a commit SHA with a version comment (actions/checkout@de0fac2e... # v6 in changelog-check.yml), and the astral-sh/setup-uv step two lines below in this same file is pinned. Pin actions/checkout the same way instead of the floating @v6 tag so the action cannot drift outside reviewed changes.

[isaaclab-review-bot]

🔵 Suggestion · Implementation — Multi-version redirect gate may mismatch target

The new gate aborts unless DOCS_DEFAULT_REF (default v3.0.0-EA) was built, while the redirect is produced by substituting __DOCS_DEFAULT_REF__ in _redirect/index.html. On this branch that template still hardcodes ./main/, so the substitution is a no-op: a build with main present fails the gate, and a passing build still redirects elsewhere. Add the placeholder to the release template or default the ref to the hardcoded target.

[isaaclab-review-bot]

🔵 Suggestion · Implementation — Marker fragments accepted without empty-content check

check_fragment returns success for any name matching MARKER_RE without inspecting contents, but the contribution guide defines <slug>.skip, <slug>.minor and <slug>.major as empty files and the towncrier config hides them with showcontent = false. A contributor who writes bullets into a tier file passes the gate and loses the entry at compile time. Reject marker files with non-whitespace content.