Repository navigation
[Release 3.0.0] Enable OV runtime in base Docker image - #8321
AntoineRichard merged 4 commits into
Conversation
|
run-ci |
There was a problem hiding this comment.
Isaac Lab Review Bot
All reviewed code categories look good.
- PR description: The scope matches the diff, but literal
\nsequences prevent most body sections from rendering; replace them with actual line breaks. - Design and architecture: Architecture looks good.
- Scope and over-engineering: No over-engineering issues.
- API: API changes look good.
- Compatibility and deprecation: No breaking changes identified.
- Implementation: Implementation looks good.
- Style consistency: Style consistency looks good.
- Test quality: Test quality looks good.
No blocking issues. No inline findings.
Automated review; human maintainers own approval decisions.
|
| # The image's package set. Kit ships in the base image, so the teleop stack comes without the | ||
| # ``isaacsim`` wheel; ``teleop`` itself is left exactly as tuned. | ||
| ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test --extra tetrahedralization" | ||
| ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test --extra tetrahedralization --extra ov" |
There was a problem hiding this comment.
Base image dependency untested The new
--extra ov makes ovphysx, ovrtx, and ovstage part of the default base image, but the Dockerfile contract tests check package installation only for the kitless image. Please add a base-image assertion for this extra or its packages; otherwise, a later edit could silently remove this fix without failing those tests.
|
run-ci |
|
run-ci |
|
run-ci |
Description
Enable the root
ovextra in the release base Docker image so its locked environment includesovphysx,ovrtx, andovstage. This alignsrelease/3.0.0with the base-image dependency set ondevelopand fixes OVRTX-backed task configurations failing during standard Docker package tests withModuleNotFoundError: No module named 'ovrtx'.\n\nThis is a focused release-branch workflow fix for the CI failure exposed by #8318. It does not change dependency pins or the lockfile.\n\n## Type of change\n\n- Bug fix (non-breaking Docker dependency fix)\n\n## Release backport\n\nNot applicable; this PR targetsrelease/3.0.0directly.\n\n## Screenshots\n\nNot applicable.\n\n## Validation\n\n-uv run --extra test python -m pytest docker/test/test_dockerfile_nonroot.py— 24 passed\n-SKIP=check-changelog-fragments uv run isaaclab -f— all applicable formatting and lint hooks passed\n-git diff --check\n\nThe full formatting command’s changelog hook compares the release snapshot againstdevelopand reports the release branch’s already-compiled fragments. Nosource/<package>files are changed, so no package changelog fragment applies.\n\n## Checklist\n\n- [x] I have read and understood the contribution guidelines\n- [x] I have run the applicable formatting and lint checks\n- [x] Documentation changes are not required for this Docker dependency fix\n- [x] My changes generate no new warnings\n- [x] I have validated the closest Docker contract tests\n- [x] No source package changed, so no package changelog fragment is required\n- [x] My name already exists inCONTRIBUTORS.md