Skip to content

[Release 3.0.0] Enable OV runtime in base Docker image - #8321

Merged
AntoineRichard merged 4 commits into
isaac-sim:release/3.0.0from
kellyguo11:kellyg/release-base-docker-ovrtx
Oct 6, 2026
Merged

AntoineRichard merged 4 commits into
isaac-sim:release/3.0.0from
kellyguo11:kellyg/release-base-docker-ovrtx

Conversation

@kellyguo11

Copy link
Copy Markdown
Contributor

Description

Enable the root ov extra in the release base Docker image so its locked environment includes ovphysx, ovrtx, and ovstage. This aligns release/3.0.0 with the base-image dependency set on develop and fixes OVRTX-backed task configurations failing during standard Docker package tests with ModuleNotFoundError: No module named 'ovrtx'.\n\nThis is a focused release-branch workflow fix for the CI failure exposed by #8318. It does not change dependency pins or the lockfile.\n\n## Type of change\n\n- Bug fix (non-breaking Docker dependency fix)\n\n## Release backport\n\nNot applicable; this PR targets release/3.0.0 directly.\n\n## Screenshots\n\nNot applicable.\n\n## Validation\n\n- uv run --extra test python -m pytest docker/test/test_dockerfile_nonroot.py — 24 passed\n- SKIP=check-changelog-fragments uv run isaaclab -f — all applicable formatting and lint hooks passed\n- git diff --check\n\nThe full formatting command’s changelog hook compares the release snapshot against develop and reports the release branch’s already-compiled fragments. No source/<package> files are changed, so no package changelog fragment applies.\n\n## Checklist\n\n- [x] I have read and understood the contribution guidelines\n- [x] I have run the applicable formatting and lint checks\n- [x] Documentation changes are not required for this Docker dependency fix\n- [x] My changes generate no new warnings\n- [x] I have validated the closest Docker contract tests\n- [x] No source package changed, so no package changelog fragment is required\n- [x] My name already exists in CONTRIBUTORS.md

@kellyguo11
kellyguo11 requested a review from a team October 6, 2026 05:21
@kellyguo11

Copy link
Copy Markdown
Contributor Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Oct 6, 2026

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

All reviewed code categories look good.

  • PR description: The scope matches the diff, but literal \n sequences prevent most body sections from rendering; replace them with actual line breaks.
  • Design and architecture: Architecture looks good.
  • Scope and over-engineering: No over-engineering issues.
  • API: API changes look good.
  • Compatibility and deprecation: No breaking changes identified.
  • Implementation: Implementation looks good.
  • Style consistency: Style consistency looks good.
  • Test quality: Test quality looks good.

No blocking issues. No inline findings.

Automated review; human maintainers own approval decisions.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[High risk] Adds a new optional dependency to the base Docker image.

The PR appears safe to merge, with a non-blocking test-coverage gap for the new base-image dependency contract.

Findings

  1. P2 Base image dependency untested ▶

Summary

The PR adds the root ov extra to the release base Docker image’s default dependency set, making its locked OV runtime packages available to Docker tasks.

  • The existing Dockerfile contract tests do not assert that the base image selects those packages.

Reviews (1) · Last reviewed commit: "Enable OV runtime in release base Docker..."

Comment thread docker/Dockerfile.base
# The image's package set. Kit ships in the base image, so the teleop stack comes without the
# ``isaacsim`` wheel; ``teleop`` itself is left exactly as tuned.
ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test --extra tetrahedralization"
ARG IMAGE_EXTRAS="--extra sb3 --extra skrl --extra rl-games --extra rsl-rl --extra viser --extra rerun --extra mimic --extra teleop --extra test --extra tetrahedralization --extra ov"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Base image dependency untested The new --extra ov makes ovphysx, ovrtx, and ovstage part of the default base image, but the Dockerfile contract tests check package installation only for the kitless image. Please add a base-image assertion for this extra or its packages; otherwise, a later edit could silently remove this fix without failing those tests.

@kellyguo11

Copy link
Copy Markdown
Contributor Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Oct 6, 2026
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Oct 6, 2026
@ooctipus

ooctipus commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Oct 6, 2026
@ooctipus

ooctipus commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Oct 6, 2026
@AntoineRichard
AntoineRichard merged commit 6864dd1 into isaac-sim:release/3.0.0 Oct 6, 2026
57 checks passed
@ooctipus
ooctipus deleted the kellyg/release-base-docker-ovrtx branch October 7, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants