Repository navigation
Improve backport conflict resolution context and models #8556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hujc7
wants to merge
5
commits into
isaac-sim:main
Choose a base branch
from
hujc7:jichuanh/backport-resolver-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
acbb2b1
Update backport conflict-resolution models to GPT-6.1 Sol and Claude …
hujc7 a2fbd01
Give the backport resolver the source PR context and release-tree tools
hujc7 f94c7ea
Report failed backports on the source PR
hujc7 145f207
Accept declared extra edits to cleanly merged source paths
hujc7 55916f4
Shorten the failed-backport comment to one line
hujc7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new kept-path and extra-path exceptions have no automated tests. The reported offline checks cover successful historical resolutions, but not the checks that must still reject a bad candidate. Future changes could weaken these checks or reject valid backports unnoticed.
Add tests using temporary Git repositories to prove that:
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!