Repository navigation
Add NVIDIA Warp ML framework support for skrl #8767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c9d23b4
791f133
2b508b1
76049ac
cebb14f
d216a7d
f149f16
19449e8
3d2dd51
7ce2d93
a8405f7
6a1917a
c8b4a52
870c4da
da943d9
cafc466
61a39a6
05fbeb9
4e5942e
76e623a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,9 +150,9 @@ dev = [ | |
|
|
||
| sb3 = ["stable-baselines3>=2.6", "tqdm", "rich"] | ||
|
|
||
| skrl = ["skrl>=2.1.0"] | ||
|
|
||
| skrl-jax = ["jax[cuda13] ; sys_platform == 'linux'", "skrl[jax]>=2.1.0"] | ||
| skrl = ["skrl>=2.1.1"] | ||
| skrl-warp = ["skrl[warp]>=2.1.1"] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since isaaclab already ships with warp, I think we can just modify the original skrl extra to be skrl[warp], this avoid the the new extra
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. skrl's Warp implementation depends on warp-lang and warp-nn (this last one not included in Isaac Lab by default). That is why this extra is needed
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes but you can just modify the base skrl extra to install skrl[warp], that avoid the additional extra definition.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. skrl has 3 implementations: PyTorch, JAX and Warp. The base skrl extra is the PyTorch implementation. For JAX and Warp, there are separated extra since they have dependencies that do not exist in Isaac Lab by default. Now, if your proposal is to install the skrl's PyTorch and Warp implementation at the same time using the base skrl extra, I can do it. If not, please provide a contrete implementation example you are referring to rather that describing it. |
||
| skrl-jax = ["jax[cuda13] ; sys_platform == 'linux'", "skrl[jax]>=2.1.1"] | ||
|
|
||
| rl-games = [ | ||
| "aiohttp>=3.14.3", # security floor; allow Isaac Sim kernels to select their exact version | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| * Added ``"warp"`` as an ``ml_framework`` option to :func:`~isaaclab_rl.skrl.import_skrl_runner` and to the | ||
| ``--ml_framework`` argument of the skrl train/play entrypoints, enabling training with skrl's Warp | ||
| implementation. Install it with the ``skrl-warp`` extra. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| * Changed the minimum supported skrl version to 2.1.1, which is required for the Warp ML framework. | ||
| * Changed the skrl train/play run summary to show the selected ML framework. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.