Repository navigation
Conversation
This was referenced Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace local learned-dynamics implementations with these PhysicsNeMo Robotics components:
JointStateCodec+GravityEncoder: replace Isaac Lab's heading conversion and gravity-feature math.FieldNormalizer: replaces separate offline NeRD training/deployment normalization.RunningNormalizer: replaces SuperMimic's localRunningNormin its world model, policy and critic.LearnedDynamicsSolver+DynamicsInferenceSession: replace local history/reset buffers, prediction orchestration and state-writeback/FK code; add resident temporal caching.NeRD networks and contact encoders were already reused before this PR. Isaac Lab retains tasks, capture, physical-model checks, dataset loading, replay, optimization and checkpoint orchestration.
Actual code reduction: 59 production Python lines. 13 existing files change; including tests/docs, the net change is +20 lines. The main diff includes unmerged prerequisites.
Prototype inference: 4.0× faster at 128 worlds (1.30 → 0.324 ms); 12.2× at 4,096 (19.52 → 1.60 ms). RTX 5090, FP32, CUDA graphs; excludes collision, FK, sensors and policy/training. End-to-end throughput remains unmeasured.
Validated: 15 integration tests, MLP/NeRD training smokes, normalization parity, formatting and docs passed.
Migration: NeRD v2 checkpoints need refitting; SuperMimic checkpoints remain compatible. Both SuperMimic learners require PhysicsNeMo here.
Isaac Lab dependencies: #8825/#8826 and shared #8822. They do not require this follow-up's new support commit.
External dependency: PhysicsNeMo Robotics (internal repository, package
physicsnemo_robotics), local branchfeat/resident-dynamics-ownership, required commite597e95bedb1f3f90637f178c045bc70c944e5d2. This support is unpublished; no dependency MR exists yet because push access was denied. This PR remains draft until publication and package compatibility are resolved.Contribution checklist