Skip to content

Test that the Warp observation manager keeps group settings out of its terms - #8857

Draft
hujc7 wants to merge 1 commit into
isaac-sim:mainfrom
hujc7:jichuanh/warp-obs-history-order-test
Draft

hujc7 wants to merge 1 commit into
isaac-sim:mainfrom
hujc7:jichuanh/warp-obs-history-order-test

Conversation

@hujc7

@hujc7 hujc7 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Adds the regression test for main's fix in #8356: the Warp observation manager parsed ObservationGroupCfg.history_order as an observation term and rejected the group. The test builds the manager with a group whose settings are all at their defaults and checks that only the two terms are parsed.

Type of change

  • Test-only change (no source package behaviour changes; .skip changelog fragment)

Screenshots

Not applicable.

Checklist

Docker and GPU tests run on demand. Push the commits you want tested, then
comment run-ci on the pull request.

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with uv run isaaclab --format
  • I have made corresponding changes to the documentation (not applicable)
  • My changes generate no new warnings
  • I have validated the changed behavior with focused coverage and applied the test-audit criteria to any test changes
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (a .skip fragment: test-only change)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant