Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the regression test for main's fix in #8356: the Warp observation manager parsed
ObservationGroupCfg.history_orderas an observation term and rejected the group. The test builds the manager with a group whose settings are all at their defaults and checks that only the two terms are parsed.mainwithout Kit (about 2 s); removing"history_order"from the manager's group settings, which reverts [Bugfix] Skip history_order when parsing Warp observation terms #8356's fix, turns it red (TypeError: ... 'history_order' is not of type ObservationTermCfg).Type of change
.skipchangelog fragment)Screenshots
Not applicable.
Checklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks withuv run isaaclab --formatsource/<pkg>/changelog.d/for every touched package (a.skipfragment: test-only change)CONTRIBUTORS.mdor my name already exists there