Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static layers workflow writes its intermediate layers as GeoTIFFs in the scratch directory and keeps them open (
isce3.io.Rasterobjects) untilrun_static_layers_workflowreturns, i.e., afterscratch_directoryhas removed the directory withshutil.rmtree..nfsXXXXfile, so the directory is not empty andrmtreefails withOSError: [Errno 39] Directory not empty: 'scratch'.The same NFS behavior was reported in #207 for the scratch directory of nisarqa, when running the RSLC and InSAR PGEs with the working directory on NFS (at HECC, and on the on-demand systems). So the static layers workflow can fail in the same environments.
This PR closes these rasters with
Raster.close_dataset()at the end of thescratch_directoryblock, after they are written to the product, so the files are closed before the directory is removed.Testing:
tests/python/packages/nisar/workflows/static.pywas run from a directory on NFS..nfsXXXXfiles inscratch, one for each open raster. The second case passed only becausescratchthen existed and was not removed.scratchis removed.