fix(ui): recount failed-download aggregates and restore card icon colors - #1201
Merged
Merged
Conversation
everpcpc
added a commit
that referenced
this pull request
Oct 4, 2026
## Problem The library add/edit form's Scanner tab holds its "add exclusion" text field state locally. On iOS/macOS the form's sections are swapped by a segmented tab picker, so leaving the Scanner tab destroys the section view and any half-typed exclusion text with it. (Missed from the nit batch in #1201.) ## Fix Hoist `newExclusion` from `LibraryFormScannerSection` to `LibraryFormSections`, which persists across tab switches, and pass it down as a binding. No behavior change otherwise. ## Validation - `make format` - `make build` — iOS, macOS, tvOS all pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to the four-batch UI review (#1197–#1200), fixing two regressions that round introduced, plus the nits called out in the post-merge review:
retryFailedBooks/cancelFailedBooksrewrite book-leveldownloadStatusRawin bulk without recounting the series/read-list rollups. With the new aggregatefailedstate, Cancel All Failed left the aggregate pinned atfailed(red icon stuck until some unrelated download event happened to trigger a recount), and Retry All Failed violated the "any pending → pending" rule until each book's next status change.DownloadStatus.displayColoris non-optional (.secondaryfor everything but failures), so thedownloadColor ?? palette.metaColor/?? style.secondaryColorfallbacks inHorizontalCardSkeletonandGridCardViewnever fired — horizontal cards on a cover tint lost their white-70% accessory color, and overlay-mode grid cards lost their white-85% icon color.Label: %@xkeys to stay.Fix
recountDownloadAggregateshelper; bulk writes bypass the per-book delta path).failureColor: Color?(red only on failure, nil otherwise) toDownloadStatus/SeriesDownloadStatusand pass it at the five palette-surface call sites, so tinted/overlay cards keep their palette colors and only failures turn red. Concrete surfaces (chips, rows, status lines) keep the non-optionaldisplayColor.LabeledSliderRowcomponent (label + trailing value above, slider below); the seven staleLabel: %@xkeys are removed.withAnimationbinding (the border-cropping picker needs none — its caption is static).Validation
make formatmake build— iOS, macOS, tvOS all passmake localize+misc/translate.py list— no missing translations