Repository navigation
Fade Restoration: suggest Remove Stain on dim scans and mild stains - #1591
Merged
marcinz606 merged 1 commit intoNov 1, 2026
Merged
Conversation
The suggestion missed heavily stained frames whose white sat just over 0.1 D under full scale, and mild stains under the 0.2 D gap. The white may now sit 0.2 D under full scale, and blue must be at least 0.08 D below both red and green. A smaller gap from the brightest channel alone would also flag red casts, where blue sits just under red. Survey of 138 frames: all 10 new flags are in the stained set; none in the Toppenhaug or FADED_SLIDES folders; no frame lost its flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimate missed the Remove Stain suggestion on clearly stained slides in two cases: a heavy stain on a scan placed just over 0.1 D under full scale, and a mild stain under the 0.2 D blue gap. The white may now sit 0.2 D under full scale, and blue must be at least 0.08 D below both red and green. Testing against both channels keeps red casts out, where blue sits just under red.
I surveyed 138 slides. The retuned test flags 10 more frames, all from the stained set, and flags none in two folders of faded slides without a yellow stain. No frame that was flagged before loses its flag. The suggestion only turns the icon amber, and renders do not change, so no version bump.