Repository navigation
[pull] develop from isaac-sim:develop - #84
Merged
Merged
Conversation
## Description Remove the unsupported `Isaac-Reorient-Franka` task registration, configuration, example, and browser entry. This is the requested breaking removal; downstream users who still need it must keep a local copy or migrate to a maintained reorientation task. This is part 1 of the split of #7829 and is independently reviewable. ## Validation - `test_lift_env_cfg.py`: 12 passed - `uv run --frozen isaaclab -f`: passed - Generated environment browser and changelog checks: passed ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop`
## Description Kit-dependent combinations repeatedly fail the performance smoke job before producing usable measurements. Remove those six combinations and retain four Kit-free runs: Newton Cartpole, Newton G1, and Shadow Hand camera benchmarks using the Newton renderer with Newton or OvPhysX physics. Remove obsolete task thresholds, disabled hard-floor entries, Kit launch environment variables, and an unused step ID. Simplify status handling and reduce the job timeout to 450 minutes, accounting for three samples and one retry per sample. The retained combinations keep identical resolved thresholds and baseline contracts; Cartpole remains advisory-only. ## Type of change - Bug fix (CI configuration) ## Validation - All 8 performance comparison tests passed. - Repository formatting and lint checks passed against the PR base. - Benchmark shell steps passed `bash -n`. - Confirmed the four retained combinations resolve to the same thresholds before and after cleanup. - Full GPU benchmark execution remains for CI. ## Release backport - [ ] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Checklist - [x] I have read and understood the contribution guidelines. - [x] I have run the pre-commit checks with `uv run isaaclab --format`. - [x] I have validated the changed behavior with focused coverage; no tests were changed. - [x] My name already exists in `CONTRIBUTORS.md`. - Documentation and package changelog fragments are not applicable: only CI workflow and tooling policy changed.
# Description The Newton `RigidObjectCollection` merged its members' prim path expressions into one wildcard glob (`_build_combined_pattern`), because older Newton could not accept a list of patterns. That approximation has two failures: - It over-matches rigid bodies with similar names. With members `Object_A` and `Object_B`, the glob `/World/Env_*/Object_*` also selects an unrelated `Object_Target` in the same environment, and initialization fails with `RuntimeError: ... matched 3 objects per world, but the collection config contains 2`. - It cannot represent members at different hierarchy depths. `Object_A` and `Shelf/Object_B` fail with `ValueError: Cannot build combined pattern: path expressions have different segment counts`. Newton 1.6.0, the pinned version, accepts the individual patterns: `ArticulationView` matches each label against a list of globs. This PR passes the members' patterns directly, as suggested in #6147, and removes the obsolete wildcard-merging workaround. This matches the PhysX collection, which already passes the list to `create_rigid_body_view`. The per-world count check is kept. Newton matches each body once, so two members whose prim paths resolve to the same prim produce one match per world. Without the check, a 4-environment scene with such an aliased pair initializes without error, but it reports `num_instances=2` and a pose buffer of shape `(4, 1, 3)`. With the check, it raises a clear error. Fixes #6147 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Test Extended the existing Newton `test_initialization` in `source/isaaclab_newton/test/assets/test_rigid_object_collection.py`; no separate regression test or fixture was added. The cases cover a single member, an unrelated `Object_Target` alongside `Object_A/B/C`, and members at different depths (`Object_A` and `Shelf/Object_B`). All run on CPU and CUDA and check each body's name-to-pose mapping as well as view counts and buffer shapes. The two regression cases fail against the original implementation at `eb6617cda` and pass with the fix. Local collection-suite validation: | Backend | Devices | Result | | --- | --- | --- | | Newton 1.6.0 | CPU and CUDA | 22 passed | | OVPhysX 0.6.3 | CPU and CUDA | 28 passed | | Kit PhysX | CPU and CUDA | 38 passed | Separate local cross-backend checks also passed both path cases on each backend, including targeted pose writes, stepping, and reset. The consolidated Newton suite was rerun after the test cleanup; the PhysX and OVPhysX implementations were unchanged. `uv run --no-sync isaaclab -f` passed, including the changelog check. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `uv run isaaclab --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have validated the changed behavior with focused coverage and applied the [test-audit criteria](https://github.com/isaac-sim/IsaacLab/blob/develop/skills/developer/test-audit/SKILL.md) to any test changes - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump package versions; CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Yusuf Guenena <yusuf.a.guenena@gmail.com> Co-authored-by: Octi Zhang <zhengyuz@nvidia.com>
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )