Repository navigation
[Nexthop][feature] "asic_config_v3" - Add DNX support to the asic config content validator - #1736
Closed
marif-nexthop wants to merge 1 commit into
Closed
marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
marif-nexthop
marked this pull request as ready for review
October 8, 2026 20:01
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-validator-dnx
branch
from
October 8, 2026 22:01
679a334 to
67576e7
Compare
2 tasks done
marif-nexthop
force-pushed
the
marif.fboss-asic-config-v3-validator-dnx
branch
from
October 15, 2026 07:41
67576e7 to
2eb9931
Compare
Contributor
Author
|
Talked to @joseph5wu offline and decided to close this PR in favour of the DNX validation added by him earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Implements
asic_config_v3design.In this PR, the content validator verifies DNX (JSON) output the same way as XGS (YAML).
main, so JSON output is still compared against<platform>.materialized_JSONas added with [Nexthop][NPI] "asic_config_v3" - Broadcom DNX generator, vendor data and meru800bia platform #1583.HW_TESTvariant is compared against the ASIC config embedded infboss/oss/hw_test_configs/<platform>.agent.materialized_JSON: theyamlConfigstring for XGS, theconfigmapping for DNX.SEMANTIC_MATCH).VARIANTS_WITHOUT_SYNCED_REFERENCE, which is currently empty. A missingHW_TESTreference always fails.Also added the symlink
synced_asic_configs/meru800bia_default.json -> meru800bia.materialized_JSONso that themeru800biadefault variant resolves to its synced reference.Test Plan
Ran the content validator against the checked-in generated files:
All variants match, and the new unit tests for YAML and JSON result classification, materialized reference extraction, and the missing reference policy pass. Regenerating
meru800biainstead of reading the checked-in file also givesBYTE_MATCH.Ran the schema validator. All 15 vendor, ASIC and platform configs pass, including
jericho3.jsonandmeru800bia: